diff options
| author | Joshua Colp <jcolp@digium.com> | 2018-03-21 13:52:08 +0000 |
|---|---|---|
| committer | Joshua Colp <jcolp@digium.com> | 2018-03-27 08:39:00 -0600 |
| commit | e14b0e960d99aaf9c75b23814a1bef22ab2a53ff (patch) | |
| tree | 25a3acf7fced71385f3784401209af903a917734 /codecs | |
| parent | a4a5b8d562b0e0f10024f7dcbfaf2cb740e81d15 (diff) | |
res_rtp_asterisk: Add support for raising additional RTCP messages.
This change extends the existing AST_FRAME_RTCP frame type to be
able to contain additional RTCP message types, such as feedback
messages. The payload type is contained in the subclass which allows
knowing what is in the frame itself.
The RTCP feedback message type is now handled and REMB[1] messages
are raised with their containing information.
This also fixes a bug where all feedback messages were triggering
video updates instead of just FIR and FUR.
Finally RTCP frames are now passed up through the Asterisk core to
what is handling the channel, mapped appropriately in the case of
bridging, and written to an outgoing stream. Since RTCP frames are
on a per-stream basis this is only done on multistream capable
channels.
[1] https://tools.ietf.org/html/draft-alvestrand-rmcat-remb-03
ASTERISK-27758
ASTERISK-26366
Change-Id: I680da0ad8d5059d5e9655d896fb9d92e9da8491e
Diffstat (limited to 'codecs')
| -rw-r--r-- | codecs/codec_speex.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/codecs/codec_speex.c b/codecs/codec_speex.c index 0a9359620..591fce9de 100644 --- a/codecs/codec_speex.c +++ b/codecs/codec_speex.c @@ -372,6 +372,11 @@ static void lintospeex_feedback(struct ast_trans_pvt *pvt, struct ast_frame *fee if(!exp_rtcp_fb) return; + /* We only accept feedback information in the form of SR and RR reports */ + if (feedback->subclass.integer != AST_RTP_RTCP_SR && feedback->subclass.integer != AST_RTP_RTCP_RR) { + return; + } + rtcp_report = (struct ast_rtp_rtcp_report *)feedback->data.ptr; if (rtcp_report->reception_report_count == 0) return; |