diff options
| author | Sean Bright <sean.bright@gmail.com> | 2017-04-14 14:52:59 -0400 |
|---|---|---|
| committer | Sean Bright <sean.bright@gmail.com> | 2017-04-17 14:51:04 -0500 |
| commit | e24bbf318c8f07bb379926c259e669affb5c9566 (patch) | |
| tree | 3248ee094d6a746ff5e393449efda84a492c7b2c /formats | |
| parent | eaecccf25930d091f979721066363097f6d8403a (diff) | |
format_wav: Read 16khz wav samples properly
When opening a PCM wave file for reading, we aren't tracking the
frequency of the opened file, so we treat 16khz files as 8khz and do
half reads.
This patch also cleans up some of the data types and an unnecessarily
complex `if` expression.
ASTERISK-26613 #close
Reported by: Vitaly K
Change-Id: I05f8b263058dc573ea8ffe0c62e7964506e11815
Diffstat (limited to 'formats')
| -rw-r--r-- | formats/format_wav.c | 24 |
1 files changed, 14 insertions, 10 deletions
diff --git a/formats/format_wav.c b/formats/format_wav.c index 06ed941b3..d06931e73 100644 --- a/formats/format_wav.c +++ b/formats/format_wav.c @@ -82,9 +82,8 @@ struct wav_desc { /* format-specific parameters */ static int check_header_fmt(FILE *f, int hsize, int hz) { - short format, chans, bysam, bisam; - int bysec; - int freq; + unsigned short format, chans, bysam, bisam; + unsigned int freq, bysec; if (hsize < 16) { ast_log(LOG_WARNING, "Unexpected header size %d\n", hsize); return -1; @@ -94,7 +93,7 @@ static int check_header_fmt(FILE *f, int hsize, int hz) return -1; } if (ltohs(format) != 1) { - ast_log(LOG_WARNING, "Not a supported wav file format (%d). Only PCM encoded, 16 bit, mono, 8kHz files are supported with a lowercase '.wav' extension.\n", ltohs(format)); + ast_log(LOG_WARNING, "Not a supported wav file format (%d). Only PCM encoded, 16 bit, mono, 8kHz/16kHz files are supported with a lowercase '.wav' extension.\n", ltohs(format)); return -1; } if (fread(&chans, 1, 2, f) != 2) { @@ -109,10 +108,9 @@ static int check_header_fmt(FILE *f, int hsize, int hz) ast_log(LOG_WARNING, "Read failed (freq)\n"); return -1; } - if (((ltohl(freq) != 8000) && (ltohl(freq) != 16000)) || - ((ltohl(freq) == 8000) && (hz != 8000)) || - ((ltohl(freq) == 16000) && (hz != 16000))) { - ast_log(LOG_WARNING, "Unexpected frequency mismatch %d (expecting %d)\n", ltohl(freq),hz); + freq = ltohl(freq); + if ((freq != 8000 && freq != 16000) || freq != hz) { + ast_log(LOG_WARNING, "Unexpected frequency mismatch %d (expecting %d)\n", freq, hz); return -1; } /* Ignore the byte frequency */ @@ -325,9 +323,15 @@ static int wav_open(struct ast_filestream *s) /* We don't have any header to read or anything really, but if we did, it would go here. We also might want to check and be sure it's a valid file. */ - struct wav_desc *tmp = (struct wav_desc *)s->_private; - if ((tmp->maxlen = check_header(s->f, ast_format_get_sample_rate(s->fmt->format))) < 0) + struct wav_desc *tmp = s->_private; + unsigned int sample_rate = ast_format_get_sample_rate(s->fmt->format); + + tmp->maxlen = check_header(s->f, sample_rate); + if (tmp->maxlen < 0) { return -1; + } + + tmp->hz = sample_rate; return 0; } |