diff options
author | Matthew Jordan <mjordan@digium.com> | 2013-06-17 03:00:38 +0000 |
---|---|---|
committer | Matthew Jordan <mjordan@digium.com> | 2013-06-17 03:00:38 +0000 |
commit | 6258bbe7bd1885ac5dec095ed0c4490c83a99f44 (patch) | |
tree | ff2794f730ca55903a09b9fe7f73f45169a71386 /funcs/func_channel.c | |
parent | 67e35c7b4748c3cef954820a2b182e2a5edf8d98 (diff) |
Update Asterisk's CDRs for the new bridging framework
This patch is the initial push to update Asterisk's CDR engine for the new
bridging framework. This patch guts the existing CDR engine and builds the new
on top of messages coming across Stasis. As changes in channel state and bridge
state are detected, CDRs are built and dispatched accordingly. This
fundamentally changes CDRs in a few ways.
(1) CDRs are now *very* reflective of the actual state of channels and bridges.
This means CDRs track well with what an actual channel is doing - which
is useful in transfer scenarios (which were previously difficult to pin
down). It does, however, mean that CDRs cannot be 'fooled'. Previous
behavior in Asterisk allowed for CDR applications, channels, and other
properties to be spoofed in parts of the code - this no longer works.
(2) CDRs have defined behavior in multi-party scenarios. This behavior will not
be what everyone wants, but it is a defined behavior and as such, it is
predictable.
(3) The CDR manipulation functions and applications have been overhauled. Major
changes have been made to ResetCDR and ForkCDR in particular. Many of the
options for these two applications no longer made any sense with the new
framework and the (slightly) more immutable nature of CDRs.
There are a plethora of other changes. For a full description of CDR behavior,
see the CDR specification on the Asterisk wiki.
(closes issue ASTERISK-21196)
Review: https://reviewboard.asterisk.org/r/2486/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@391947 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'funcs/func_channel.c')
-rw-r--r-- | funcs/func_channel.c | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/funcs/func_channel.c b/funcs/func_channel.c index 937924400..4327fd257 100644 --- a/funcs/func_channel.c +++ b/funcs/func_channel.c @@ -343,13 +343,6 @@ ASTERISK_FILE_VERSION(__FILE__, "$Revision$") </function> ***/ -/* - * BUGBUG add CHANNEL(after_bridge_goto)=<parseable-goto> Sets an after bridge goto datastore property on the channel. - * CHANNEL(after_bridge_goto)=<empty> Deletes any after bridge goto datastore property on the channel. - * - * BUGBUG add CHANNEL(dtmf_features)=tkhwx sets channel dtmf features to specified. (transfer, park, hangup, monitor, mixmonitor) - */ - #define locked_copy_string(chan, dest, source, len) \ do { \ ast_channel_lock(chan); \ @@ -450,7 +443,7 @@ static int func_channel_read(struct ast_channel *chan, const char *function, ast_channel_lock(chan); p = ast_bridged_channel(chan); - if (p || ast_channel_tech(chan) || ast_channel_cdr(chan)) /* dummy channel? if so, we hid the peer name in the language */ + if (p || ast_channel_tech(chan)) /* dummy channel? if so, we hid the peer name in the language */ ast_copy_string(buf, (p ? ast_channel_name(p) : ""), len); else { /* a dummy channel can still pass along bridged peer info via @@ -525,7 +518,7 @@ static int func_channel_write_real(struct ast_channel *chan, const char *functio locked_string_field_set(chan, userfield, value); else if (!strcasecmp(data, "amaflags")) { ast_channel_lock(chan); - if(isdigit(*value)) { + if (isdigit(*value)) { int amaflags; sscanf(value, "%30d", &amaflags); ast_channel_amaflags_set(chan, amaflags); |