diff options
| author | David M. Lee <dlee@digium.com> | 2013-01-14 15:58:01 +0000 |
|---|---|---|
| committer | David M. Lee <dlee@digium.com> | 2013-01-14 15:58:01 +0000 |
| commit | d3bb2506a17ee210f893dd57b9dbc69f235de87e (patch) | |
| tree | 6578ee28f450a1b833f90649dd910dcec09fd8ba /include/asterisk/manager.h | |
| parent | a91a2891540d72ec6653796ad7a332539e794932 (diff) | |
Gently reduce masquerade insanity
Masquerades are an insane implementation detail within Asterisk. It generates
a number of useless and confusing events, and manipulates channels in a way
that semantically doesn't make sense. I've given a fairly thorough review of
masquerade code and its usage on the wiki at
https://wiki.asterisk.org/wiki/x/IwBRAQ.
While ultimately it makes the most sense to abandon masquerades altogether,
it will take some time to completely irradicate. Even then, there may always
be code that's not worth rewriting to get rid of the masquerade.
This patch does two things to make masquerades slightly less insane:
* When swapping the names of the original and clone channel, only emit a
single rename event of original -> original<ZOMBIE>. The original code
issued three rename events to accomplish the same end.
* In addition to swapping the names of the channels, also swap their
uniqueid's. This allows the 'Uniqueid' field to be used as a stable
identifier for a channel from and external interface, such as AMI.
Review: https://reviewboard.asterisk.org/r/2266/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@379023 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'include/asterisk/manager.h')
| -rw-r--r-- | include/asterisk/manager.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/asterisk/manager.h b/include/asterisk/manager.h index fd58b7ae7..2e58a119a 100644 --- a/include/asterisk/manager.h +++ b/include/asterisk/manager.h @@ -54,7 +54,7 @@ - \ref manager.c Main manager code file */ -#define AMI_VERSION "1.3" +#define AMI_VERSION "1.4" #define DEFAULT_MANAGER_PORT 5038 /* Default port for Asterisk management via TCP */ #define DEFAULT_MANAGER_TLS_PORT 5039 /* Default port for Asterisk management via TCP */ |