diff options
| author | David M. Lee <dlee@digium.com> | 2013-12-16 19:11:51 +0000 |
|---|---|---|
| committer | David M. Lee <dlee@digium.com> | 2013-12-16 19:11:51 +0000 |
| commit | 744556c01d6e28d4ae46c347f77edfb71778d924 (patch) | |
| tree | bc90f83b4ec9ef0eafb3d952076bf9ea24406366 /main/asterisk.c | |
| parent | 00dcee2a640394ac0aae294396d96985c6c1aba1 (diff) | |
security: Inhibit execution of privilege escalating functions
This patch allows individual dialplan functions to be marked as
'dangerous', to inhibit their execution from external sources.
A 'dangerous' function is one which results in a privilege escalation.
For example, if one were to read the channel variable SHELL(rm -rf /)
Bad Things(TM) could happen; even if the external source has only read
permissions.
Execution from external sources may be enabled by setting
'live_dangerously' to 'yes' in the [options] section of asterisk.conf.
Although doing so is not recommended.
Also, the ABI was changed to something more reasonable, since Asterisk
12 does not yet have a public release.
(closes issue ASTERISK-22905)
Review: http://reviewboard.digium.internal/r/432/
........
Merged revisions 403913 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........
Merged revisions 403917 from http://svn.asterisk.org/svn/asterisk/branches/11
........
Merged revisions 403959 from http://svn.asterisk.org/svn/asterisk/branches/12
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@403960 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'main/asterisk.c')
| -rw-r--r-- | main/asterisk.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/main/asterisk.c b/main/asterisk.c index 74e36986f..3ed085d28 100644 --- a/main/asterisk.c +++ b/main/asterisk.c @@ -3332,6 +3332,8 @@ static void ast_readconfig(void) unsigned int dbdir:1; unsigned int keydir:1; } found = { 0, 0 }; + /* Default to true for backward compatibility */ + int live_dangerously = 1; /* Set default value */ option_dtmfminduration = AST_MIN_DTMF_DURATION; @@ -3565,8 +3567,11 @@ static void ast_readconfig(void) v->value); ast_clear_flag(&ast_options, AST_OPT_FLAG_STDEXTEN_MACRO); } + } else if (!strcasecmp(v->name, "live_dangerously")) { + live_dangerously = ast_true(v->value); } } + pbx_live_dangerously(live_dangerously); for (v = ast_variable_browse(cfg, "compat"); v; v = v->next) { float version; if (sscanf(v->value, "%30f", &version) != 1) { |