diff options
author | Mark Michelson <mmichelson@digium.com> | 2013-10-03 14:58:16 +0000 |
---|---|---|
committer | Mark Michelson <mmichelson@digium.com> | 2013-10-03 14:58:16 +0000 |
commit | ee21eee7e067573ad83bd0df492036094b4dbaca (patch) | |
tree | 024e25a92079bc7e5348bd55cc29eff2f3c38dec /main/bridge_basic.c | |
parent | c977f73e136eca1f2aaccd0ea0fe45c350906374 (diff) |
Cache string values of formats on ast_format_cap() to save processing.
Channel snapshots have string representations of the channel's native formats.
Prior to this change, the format strings were re-created on ever channel snapshot
creation. Since channel native formats rarely change, this was very wasteful.
Now, string representations of formats may optionally be stored on the ast_format_cap
for cases where string representations may be requested frequently. When formats
are altered, the string cache is marked as invalid. When strings are requested, the
cache validity is checked. If the cache is valid, then the cached strings are copied.
If the cache is invalid, then the string cache is rebuilt and copied, and the cache
is marked as being valid again.
Review: https://reviewboard.asterisk.org/r/2879
........
Merged revisions 400356 from http://svn.asterisk.org/svn/asterisk/branches/12
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@400363 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'main/bridge_basic.c')
-rw-r--r-- | main/bridge_basic.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/main/bridge_basic.c b/main/bridge_basic.c index 942a3ce25..76dfb2893 100644 --- a/main/bridge_basic.c +++ b/main/bridge_basic.c @@ -2218,7 +2218,7 @@ static void recall_callback(struct ast_dial *dial) static int recalling_enter(struct attended_transfer_properties *props) { - RAII_VAR(struct ast_format_cap *, cap, ast_format_cap_alloc_nolock(), ast_format_cap_destroy); + RAII_VAR(struct ast_format_cap *, cap, ast_format_cap_alloc(AST_FORMAT_CAP_FLAG_NOLOCK), ast_format_cap_destroy); struct ast_format fmt; if (!cap) { @@ -2346,7 +2346,7 @@ static int attach_framehook(struct attended_transfer_properties *props, struct a static int retransfer_enter(struct attended_transfer_properties *props) { - RAII_VAR(struct ast_format_cap *, cap, ast_format_cap_alloc_nolock(), ast_format_cap_destroy); + RAII_VAR(struct ast_format_cap *, cap, ast_format_cap_alloc(AST_FORMAT_CAP_FLAG_NOLOCK), ast_format_cap_destroy); struct ast_format fmt; char destination[AST_MAX_EXTENSION + AST_MAX_CONTEXT + 2]; int cause; |