diff options
| author | Mark Michelson <mmichelson@digium.com> | 2009-04-10 16:06:22 +0000 |
|---|---|---|
| committer | Mark Michelson <mmichelson@digium.com> | 2009-04-10 16:06:22 +0000 |
| commit | bdcf8fca816de8cd5420a17582907fecb5321480 (patch) | |
| tree | 6fe1e7cb6fd80d9498858f1be7eed65431f39956 /main/channel.c | |
| parent | 32cd7d1d607ddda6a3cb5f45decbee9c74148b19 (diff) | |
Don't let ast_channel_alloc fail if explicitly passed NULL cid_name or cid_number.
This also fixes a small memory leak.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@187680 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'main/channel.c')
| -rw-r--r-- | main/channel.c | 21 |
1 files changed, 16 insertions, 5 deletions
diff --git a/main/channel.c b/main/channel.c index 0c0c1c525..ed88f53f4 100644 --- a/main/channel.c +++ b/main/channel.c @@ -796,11 +796,22 @@ struct ast_channel *ast_channel_alloc(int needqueue, int state, const char *cid_ return NULL; } - if (!(tmp->cid.cid_name = ast_strdup(cid_name)) || !(tmp->cid.cid_num = ast_strdup(cid_num))) { - ast_string_field_free_memory(tmp); - sched_context_destroy(tmp->sched); - ast_free(tmp); - return NULL; + if (cid_name) { + if (!(tmp->cid.cid_name = ast_strdup(cid_name))) { + ast_string_field_free_memory(tmp); + sched_context_destroy(tmp->sched); + ast_free(tmp); + return NULL; + } + } + if (cid_num) { + if (!(tmp->cid.cid_num = ast_strdup(cid_num))) { + ast_string_field_free_memory(tmp); + sched_context_destroy(tmp->sched); + ast_free(tmp->cid.cid_name); + ast_free(tmp); + return NULL; + } } #ifdef HAVE_EPOLL |