summaryrefslogtreecommitdiff
path: root/main/config.c
diff options
context:
space:
mode:
authorMark Michelson <mmichelson@digium.com>2014-09-11 22:17:39 +0000
committerMark Michelson <mmichelson@digium.com>2014-09-11 22:17:39 +0000
commitc212a71f0bd464e93eed947a03ba9414d1d42207 (patch)
tree1473f13cb4a4c9bd05a1223b6254ba23717cf966 /main/config.c
parent93894d53c469c0703d7226c5fa7cc5d2f973dc97 (diff)
Remove undocumented default behavior of ast_play_and_record_full acceptdtmf.
ast_play_and_record_full() has a parameter called "acceptdtmf" that is a string of acceptable DTMF digits that may be pressed by a caller to end and accept the recording. ARI uses this function in order to perform recording, and it provides options for what is passed as acceptdtmf to ast_play_and_record_full(). By default, ARI passes an empty string, with the intention that no DTMF can be used to end the recording. The problem is that ast_play_and_record_full() attempts to be "helpful" by setting "#" as the acceptdtmf if an empty string or NULL pointer has been passed in. With ARI, this results in unexpected behavior occurring if you have attempted to intercept "#" yourself in order to perform some other manipulation of the live recording. This change removes the "helpful" behavior by no longer accepting "#" as a default acceptdtmf if none is specified by the caller of ast_play_and_record_full(). This makes the ARI scenario work as expected. The other callers of ast_play_and_record_full() are app_voicemail and app_minivm, and in both cases, they pass an explicit "#" to ast_play_and_record_full() as acceptdtmf, so they are unaffected by this change. ........ Merged revisions 422964 from http://svn.asterisk.org/svn/asterisk/branches/12 ........ Merged revisions 422965 from http://svn.asterisk.org/svn/asterisk/branches/13 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@422967 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'main/config.c')
0 files changed, 0 insertions, 0 deletions