summaryrefslogtreecommitdiff
path: root/main/pbx.c
diff options
context:
space:
mode:
authorRichard Mudgett <rmudgett@digium.com>2017-03-02 21:27:00 -0600
committerRichard Mudgett <rmudgett@digium.com>2017-03-02 21:46:51 -0600
commitc9296b23d1574332ccbc83f3fc7ba492cfc34cfe (patch)
treee9634d3306bd448317af9b3115fa307379c48a46 /main/pbx.c
parente9b2360d17f744cb8993672977e2688ab3491ae2 (diff)
core: Cleanup ast_get_hint() usage.
* manager.c:manager_state_cb() Fix potential use of uninitialized hint[] if a hint does not exist for the requested extension. Ran into this when developing a testsuite test. The AMI event ExtensionStatus came out with the hint header value containing garbage. The AMI event PresenceStatus also had the same issue. * manager.c:action_extensionstate() no need to completely initialize the hint[]. Only initialize the first element. * pbx.c:ast_add_hint() Remove unnecessary assignment. * chan_sip.c: Eliminate an unneeded hint[] local variable. We only care about the return value of ast_get_hint() there. Change-Id: Ia9a8786f01f93f1f917200f0a50bead0319af97b
Diffstat (limited to 'main/pbx.c')
-rw-r--r--main/pbx.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/main/pbx.c b/main/pbx.c
index 47e0b0eda..fe87d67a5 100644
--- a/main/pbx.c
+++ b/main/pbx.c
@@ -3967,7 +3967,6 @@ static int ast_add_hint(struct ast_exten *e)
hint_new->last_presence_state = presence_state;
hint_new->last_presence_subtype = subtype;
hint_new->last_presence_message = message;
- message = subtype = NULL;
}
}