diff options
| author | Mark Michelson <mmichelson@digium.com> | 2012-05-18 17:54:07 +0000 |
|---|---|---|
| committer | Mark Michelson <mmichelson@digium.com> | 2012-05-18 17:54:07 +0000 |
| commit | 11348736af2097be6ca9d99f160ead3e85e44ec2 (patch) | |
| tree | bae82375700dbfa7752f22159d17deb8d6f1315a /main/say.c | |
| parent | 5c576aa3c2bfd5b8cb13edff88692c7274d906af (diff) | |
Address MISSING_BREAK static analysis reports some more.
This addresses core findings 4 and 6.
Moises Silva helped me by stating that a break could be
safely added to the case where it is added in chan_dahdi.c
In say.c, I have added a comment indicating that static analysis
complains but that it is currently unknown if this is correct.
This fixes all core findings of this type.
(closes issue ASTERISK-19662)
reported by Matthew Jordan
........
Merged revisions 367027 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........
Merged revisions 367028 from http://svn.asterisk.org/svn/asterisk/branches/10
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@367029 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'main/say.c')
| -rw-r--r-- | main/say.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/main/say.c b/main/say.c index f4db3e0f0..9d6d4b16c 100644 --- a/main/say.c +++ b/main/say.c @@ -6127,6 +6127,9 @@ int ast_say_date_with_format_zh(struct ast_channel *chan, time_t t, const char * if (tm.tm_hour < 10) { res = wait_file(chan, ints, "digits/0", lang); } + /* XXX Static analysis warns of no break here. No idea if this is + * correct or not + */ case 'k': /* 24-Hour */ if (!(tm.tm_hour % 10) || tm.tm_hour < 10) { |