diff options
author | Corey Farrell <git@cfware.com> | 2017-11-11 11:09:29 -0500 |
---|---|---|
committer | Corey Farrell <git@cfware.com> | 2017-11-17 10:48:33 -0500 |
commit | 455b1bdeb0888f69fa21e01a804d1aa9a30e46b6 (patch) | |
tree | 28a76c04b65e30b02891b157d5f4594b55ce8e69 /menuselect/configure | |
parent | ef8ee3ee69fb1b2f9bb2694217d8dfdf124d251f (diff) |
menuselect: Remove ineffective weak attribute detection.
menuselect detects compiler support for multiple styles of weak
functions. This is a remnant from 2013 when OPTIONAL_API required weak
functions. It is no longer correct for menuselect to switch
dependencies from optional to required based on lack of weak function
support.
Note an issue remains - dependencies should switch from optional to
required based on OPTIONAL_API being enabled or disabled. I don't think
this is possible. menuselect needs to know at startup if OPTIONAL_API
is enabled or disabled, so the only way to fix this is to remove
OPTIONAL_API from menuselect and create a configure option. I've left
the code that switches in place but it's preprocessed out.
Additionally removed:
- WEAKREF variable from Asterisk makeopts.in.
- Related disabled code from test_utils.
- Pointless AC_REVISION call from menuselect/configure.ac.
Change-Id: Ifa702e5f98eb45f338b2f131a93354632a8fb389
Diffstat (limited to 'menuselect/configure')
-rwxr-xr-x | menuselect/configure | 302 |
1 files changed, 0 insertions, 302 deletions
diff --git a/menuselect/configure b/menuselect/configure index 4235ea0a4..13a330b07 100755 --- a/menuselect/configure +++ b/menuselect/configure @@ -1,5 +1,4 @@ #! /bin/sh -# From configure.ac Revision. # Guess values for system-dependent variables and create Makefiles. # Generated by GNU Autoconf 2.69. # @@ -655,7 +654,6 @@ ALLOCA EGREP GREP CPP -PBX_WEAKREF MENUSELECT_DEBUG GNU_MAKE OBJEXT @@ -2218,7 +2216,6 @@ ac_config_headers="$ac_config_headers autoconfig.h" - ac_aux_dir= for ac_dir in "$srcdir" "$srcdir/.." "$srcdir/../.."; do if test -f "$ac_dir/install-sh"; then @@ -3194,305 +3191,6 @@ fi -# Support weak symbols on a platform specific basis. The Mac OS X -# (Darwin) support must be isolated from the other platforms because -# it has caused other platforms to fail. -# -case "${OSARCH}" in - darwin*) - # Allow weak symbol support on Darwin platforms only because there - # is active community support for it. - # However, Darwin seems to break weak symbols for each new version. - # - - -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for compiler 'attribute weak_import' support" >&5 -$as_echo_n "checking for compiler 'attribute weak_import' support... " >&6; } -saved_CFLAGS="$CFLAGS" -CFLAGS="$CFLAGS -Wall -Wno-unused -Werror" -PBX_WEAKREF=0 - -if test "x" = "x" -then -cat confdefs.h - <<_ACEOF >conftest.$ac_ext -/* end confdefs.h. */ - void __attribute__((weak_import)) *test(void *muffin, ...) {return (void *) 0;} -int -main () -{ - - ; - return 0; -} -_ACEOF -if ac_fn_c_try_compile "$LINENO"; then : - { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 -$as_echo "yes" >&6; } - PBX_WEAKREF=1 - -cat >>confdefs.h <<_ACEOF -#define HAVE_ATTRIBUTE_weak_import 1 -_ACEOF - -else - { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 -$as_echo "no" >&6; } - -fi -rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext -else -cat confdefs.h - <<_ACEOF >conftest.$ac_ext -/* end confdefs.h. */ - void __attribute__(()) *test(void *muffin, ...) ; -int -main () -{ - - ; - return 0; -} -_ACEOF -if ac_fn_c_try_compile "$LINENO"; then : - { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 -$as_echo "yes" >&6; } - PBX_WEAKREF=1 - -cat >>confdefs.h <<_ACEOF -#define HAVE_ATTRIBUTE_weak_import 1 -_ACEOF - -else - { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 -$as_echo "no" >&6; } - -fi -rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext -fi - - -CFLAGS="$saved_CFLAGS" - - - - # Several other platforms including Linux have GCC versions that - # define the weak attribute. However, this attribute is only - # setup for use in the code by Darwin. - -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for compiler 'attribute weak' support" >&5 -$as_echo_n "checking for compiler 'attribute weak' support... " >&6; } -saved_CFLAGS="$CFLAGS" -CFLAGS="$CFLAGS -Wall -Wno-unused -Werror" -PBX_WEAKREF=0 - -if test "x" = "x" -then -cat confdefs.h - <<_ACEOF >conftest.$ac_ext -/* end confdefs.h. */ - void __attribute__((weak)) *test(void *muffin, ...) {return (void *) 0;} -int -main () -{ - - ; - return 0; -} -_ACEOF -if ac_fn_c_try_compile "$LINENO"; then : - { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 -$as_echo "yes" >&6; } - PBX_WEAKREF=1 - -cat >>confdefs.h <<_ACEOF -#define HAVE_ATTRIBUTE_weak 1 -_ACEOF - -else - { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 -$as_echo "no" >&6; } - -fi -rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext -else -cat confdefs.h - <<_ACEOF >conftest.$ac_ext -/* end confdefs.h. */ - void __attribute__(()) *test(void *muffin, ...) ; -int -main () -{ - - ; - return 0; -} -_ACEOF -if ac_fn_c_try_compile "$LINENO"; then : - { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 -$as_echo "yes" >&6; } - PBX_WEAKREF=1 - -cat >>confdefs.h <<_ACEOF -#define HAVE_ATTRIBUTE_weak 1 -_ACEOF - -else - { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 -$as_echo "no" >&6; } - -fi -rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext -fi - - -CFLAGS="$saved_CFLAGS" - - - ;; - linux-gnu) - # Primarily support weak symbols on Linux platforms. - # - -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for compiler 'attribute weakref' support" >&5 -$as_echo_n "checking for compiler 'attribute weakref' support... " >&6; } -saved_CFLAGS="$CFLAGS" -CFLAGS="$CFLAGS -Wall -Wno-unused -Werror" -PBX_WEAKREF=0 - -if test "xweakref("foo")" = "x" -then -cat confdefs.h - <<_ACEOF >conftest.$ac_ext -/* end confdefs.h. */ -static void __attribute__((weakref)) *test(void *muffin, ...) {return (void *) 0;} -int -main () -{ - - ; - return 0; -} -_ACEOF -if ac_fn_c_try_compile "$LINENO"; then : - { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 -$as_echo "yes" >&6; } - PBX_WEAKREF=1 - -cat >>confdefs.h <<_ACEOF -#define HAVE_ATTRIBUTE_weakref 1 -_ACEOF - -else - { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 -$as_echo "no" >&6; } - -fi -rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext -else -cat confdefs.h - <<_ACEOF >conftest.$ac_ext -/* end confdefs.h. */ -static void __attribute__((weakref("foo"))) *test(void *muffin, ...) ; -int -main () -{ - - ; - return 0; -} -_ACEOF -if ac_fn_c_try_compile "$LINENO"; then : - { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 -$as_echo "yes" >&6; } - PBX_WEAKREF=1 - -cat >>confdefs.h <<_ACEOF -#define HAVE_ATTRIBUTE_weakref 1 -_ACEOF - -else - { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 -$as_echo "no" >&6; } - -fi -rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext -fi - - -CFLAGS="$saved_CFLAGS" - - - ;; - *) - # Allow weak symbols on other platforms. However, any problems - # with this feature on other platforms must be fixed by the - # community. - # - -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for compiler 'attribute weakref' support" >&5 -$as_echo_n "checking for compiler 'attribute weakref' support... " >&6; } -saved_CFLAGS="$CFLAGS" -CFLAGS="$CFLAGS -Wall -Wno-unused -Werror" -PBX_WEAKREF=0 - -if test "xweakref("foo")" = "x" -then -cat confdefs.h - <<_ACEOF >conftest.$ac_ext -/* end confdefs.h. */ -static void __attribute__((weakref)) *test(void *muffin, ...) {return (void *) 0;} -int -main () -{ - - ; - return 0; -} -_ACEOF -if ac_fn_c_try_compile "$LINENO"; then : - { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 -$as_echo "yes" >&6; } - PBX_WEAKREF=1 - -cat >>confdefs.h <<_ACEOF -#define HAVE_ATTRIBUTE_weakref 1 -_ACEOF - -else - { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 -$as_echo "no" >&6; } - -fi -rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext -else -cat confdefs.h - <<_ACEOF >conftest.$ac_ext -/* end confdefs.h. */ -static void __attribute__((weakref("foo"))) *test(void *muffin, ...) ; -int -main () -{ - - ; - return 0; -} -_ACEOF -if ac_fn_c_try_compile "$LINENO"; then : - { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 -$as_echo "yes" >&6; } - PBX_WEAKREF=1 - -cat >>confdefs.h <<_ACEOF -#define HAVE_ATTRIBUTE_weakref 1 -_ACEOF - -else - { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 -$as_echo "no" >&6; } - -fi -rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext -fi - - -CFLAGS="$saved_CFLAGS" - - - ;; -esac ac_ext=c ac_cpp='$CPP $CPPFLAGS' |