diff options
| author | Kinsey Moore <kmoore@digium.com> | 2014-09-05 13:28:13 +0000 |
|---|---|---|
| committer | Kinsey Moore <kmoore@digium.com> | 2014-09-05 13:28:13 +0000 |
| commit | e59ae8b0c9a04aabda4956b4abbb15cb5f676826 (patch) | |
| tree | 578a3f91d972b51e5d941a249cc13b71397585c3 /menuselect | |
| parent | de07c80ede16f47c3799b6bec49ddf499bf85ea3 (diff) | |
Menuselect: Fix incorrect enabling on failed deps
This corrects a situation where menuselect can incorrectly enable a
module by default that has defaultenabled set to "no" and has
failed/non-selected dependencies. The bug is due to an inverted test
when checking for whether the given module should be set to enabled by
default on load.
Review: https://reviewboard.asterisk.org/r/3975/
Reported by: John Bigelow
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/13@422646 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'menuselect')
| -rw-r--r-- | menuselect/menuselect.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/menuselect/menuselect.c b/menuselect/menuselect.c index 6491d6938..f4a826b84 100644 --- a/menuselect/menuselect.c +++ b/menuselect/menuselect.c @@ -459,7 +459,7 @@ static int process_xml_member_node(xmlNode *node, struct category *cat) if (!cat->positive_output) { mem->enabled = 1; - if (!(mem->defaultenabled && strcasecmp(mem->defaultenabled, "no"))) { + if (!mem->defaultenabled || strcasecmp(mem->defaultenabled, "no")) { mem->was_enabled = 1; print_debug("Enabled %s because the category does not have positive output\n", mem->name); } |