diff options
author | Kinsey Moore <kmoore@digium.com> | 2014-08-07 15:30:19 +0000 |
---|---|---|
committer | Kinsey Moore <kmoore@digium.com> | 2014-08-07 15:30:19 +0000 |
commit | 0ac7f96057fb9fc0d012515f47bfea8d63eb5199 (patch) | |
tree | 8f807ace812c5d8d1cccb01b021ae050e975e550 /res/ari | |
parent | a8829490b6b9891b352e39f3846de1f274ca632c (diff) |
Stasis: Convey transfer information to applications
This fixes a class of issues where Stasis applications were not made
aware that their channels were being manipulated or replaced by
external entitiessuch as transfers, AMI commands, or dialplan
applications such as Bridge(). Inconsistent information such as
StasisEnd events with unknown channels as a result of masquerades has
also been corrected. To accomplish these fixes, several new fields
were added to blind and attended transfer messages as well as
StasisStart and BridgeAttendedTransfer Stasis events.
ASTERISK-23941 #close
Review: https://reviewboard.asterisk.org/r/3865/
Review: https://reviewboard.asterisk.org/r/3857/
Review: https://reviewboard.asterisk.org/r/3852/
Review: https://reviewboard.asterisk.org/r/3816/
Review: https://reviewboard.asterisk.org/r/3731/
Review: https://reviewboard.asterisk.org/r/3729/
Review: https://reviewboard.asterisk.org/r/3728/
........
Merged revisions 420325 from http://svn.asterisk.org/svn/asterisk/branches/12
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@420338 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'res/ari')
-rw-r--r-- | res/ari/ari_model_validators.c | 45 | ||||
-rw-r--r-- | res/ari/ari_model_validators.h | 5 |
2 files changed, 50 insertions, 0 deletions
diff --git a/res/ari/ari_model_validators.c b/res/ari/ari_model_validators.c index 10fd3bd83..be1a244df 100644 --- a/res/ari/ari_model_validators.c +++ b/res/ari/ari_model_validators.c @@ -1845,6 +1845,15 @@ int ast_ari_validate_bridge_attended_transfer(struct ast_json *json) res = 0; } } else + if (strcmp("replace_channel", ast_json_object_iter_key(iter)) == 0) { + int prop_is_valid; + prop_is_valid = ast_ari_validate_channel( + ast_json_object_iter_value(iter)); + if (!prop_is_valid) { + ast_log(LOG_ERROR, "ARI BridgeAttendedTransfer field replace_channel failed validation\n"); + res = 0; + } + } else if (strcmp("result", ast_json_object_iter_key(iter)) == 0) { int prop_is_valid; has_result = 1; @@ -1855,6 +1864,24 @@ int ast_ari_validate_bridge_attended_transfer(struct ast_json *json) res = 0; } } else + if (strcmp("transfer_target", ast_json_object_iter_key(iter)) == 0) { + int prop_is_valid; + prop_is_valid = ast_ari_validate_channel( + ast_json_object_iter_value(iter)); + if (!prop_is_valid) { + ast_log(LOG_ERROR, "ARI BridgeAttendedTransfer field transfer_target failed validation\n"); + res = 0; + } + } else + if (strcmp("transferee", ast_json_object_iter_key(iter)) == 0) { + int prop_is_valid; + prop_is_valid = ast_ari_validate_channel( + ast_json_object_iter_value(iter)); + if (!prop_is_valid) { + ast_log(LOG_ERROR, "ARI BridgeAttendedTransfer field transferee failed validation\n"); + res = 0; + } + } else if (strcmp("transferer_first_leg", ast_json_object_iter_key(iter)) == 0) { int prop_is_valid; has_transferer_first_leg = 1; @@ -2045,6 +2072,15 @@ int ast_ari_validate_bridge_blind_transfer(struct ast_json *json) res = 0; } } else + if (strcmp("transferee", ast_json_object_iter_key(iter)) == 0) { + int prop_is_valid; + prop_is_valid = ast_ari_validate_channel( + ast_json_object_iter_value(iter)); + if (!prop_is_valid) { + ast_log(LOG_ERROR, "ARI BridgeBlindTransfer field transferee failed validation\n"); + res = 0; + } + } else { ast_log(LOG_ERROR, "ARI BridgeBlindTransfer has undocumented field %s\n", @@ -4828,6 +4864,15 @@ int ast_ari_validate_stasis_start(struct ast_json *json) res = 0; } } else + if (strcmp("replace_channel", ast_json_object_iter_key(iter)) == 0) { + int prop_is_valid; + prop_is_valid = ast_ari_validate_channel( + ast_json_object_iter_value(iter)); + if (!prop_is_valid) { + ast_log(LOG_ERROR, "ARI StasisStart field replace_channel failed validation\n"); + res = 0; + } + } else { ast_log(LOG_ERROR, "ARI StasisStart has undocumented field %s\n", diff --git a/res/ari/ari_model_validators.h b/res/ari/ari_model_validators.h index beace67b2..64dd1b071 100644 --- a/res/ari/ari_model_validators.h +++ b/res/ari/ari_model_validators.h @@ -1287,7 +1287,10 @@ ari_validator ast_ari_validate_application_fn(void); * - destination_threeway_channel: Channel * - destination_type: string (required) * - is_external: boolean (required) + * - replace_channel: Channel * - result: string (required) + * - transfer_target: Channel + * - transferee: Channel * - transferer_first_leg: Channel (required) * - transferer_first_leg_bridge: Bridge * - transferer_second_leg: Channel (required) @@ -1302,6 +1305,7 @@ ari_validator ast_ari_validate_application_fn(void); * - exten: string (required) * - is_external: boolean (required) * - result: string (required) + * - transferee: Channel * BridgeCreated * - type: string (required) * - application: string (required) @@ -1467,6 +1471,7 @@ ari_validator ast_ari_validate_application_fn(void); * - timestamp: Date * - args: List[string] (required) * - channel: Channel (required) + * - replace_channel: Channel * TextMessageReceived * - type: string (required) * - application: string (required) |