diff options
author | David M. Lee <dlee@digium.com> | 2013-11-07 21:10:31 +0000 |
---|---|---|
committer | David M. Lee <dlee@digium.com> | 2013-11-07 21:10:31 +0000 |
commit | 7d0d1a1efb1d484cce28137f1abc1a6ece61d7e9 (patch) | |
tree | a61c7891a423ff7a70ae5bb3a5880ba4437702fd /res/res_ari_playback.c | |
parent | cdfbc02df164a9bc49e23900fae66e696c4623aa (diff) |
ari: User better nicknames for ARI operations
While working on building client libraries from the Swagger API, I
noticed a problem with the nicknames.
channel.deleteChannel()
channel.answerChannel()
channel.muteChannel()
Etc. We put the object name in the nickname (since we were generating C
code), but it makes OO generators redundant.
This patch makes the nicknames more OO friendly. This resulted in a lot
of name changing within the res_ari_*.so modules, but not much else.
There were a couple of other fixed I made in the process.
* When reversible operations (POST /hold, POST /unhold) were made more
RESTful (POST /hold, DELETE /unhold), the path for the second operation
was left in the API declaration. This worked, but really the two
operations should have been on the same API.
* The POST /unmute operation had still not been REST-ified.
Review: https://reviewboard.asterisk.org/r/2940/
........
Merged revisions 402528 from http://svn.asterisk.org/svn/asterisk/branches/12
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@402529 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'res/res_ari_playback.c')
-rw-r--r-- | res/res_ari_playback.c | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/res/res_ari_playback.c b/res/res_ari_playback.c index 06538f5a8..1be3f078b 100644 --- a/res/res_ari_playback.c +++ b/res/res_ari_playback.c @@ -58,11 +58,11 @@ ASTERISK_FILE_VERSION(__FILE__, "$Revision$") * \param headers HTTP headers. * \param[out] response Response to the HTTP request. */ -static void ast_ari_get_playback_cb( +static void ast_ari_playback_get_cb( struct ast_variable *get_params, struct ast_variable *path_vars, struct ast_variable *headers, struct ast_ari_response *response) { - struct ast_get_playback_args args = {}; + struct ast_ari_playback_get_args args = {}; struct ast_variable *i; #if defined(AST_DEVMODE) int is_valid; @@ -75,7 +75,7 @@ static void ast_ari_get_playback_cb( } else {} } - ast_ari_get_playback(headers, &args, response); + ast_ari_playback_get(headers, &args, response); #if defined(AST_DEVMODE) code = response->response_code; @@ -115,11 +115,11 @@ fin: __attribute__((unused)) * \param headers HTTP headers. * \param[out] response Response to the HTTP request. */ -static void ast_ari_stop_playback_cb( +static void ast_ari_playback_stop_cb( struct ast_variable *get_params, struct ast_variable *path_vars, struct ast_variable *headers, struct ast_ari_response *response) { - struct ast_stop_playback_args args = {}; + struct ast_ari_playback_stop_args args = {}; struct ast_variable *i; #if defined(AST_DEVMODE) int is_valid; @@ -132,7 +132,7 @@ static void ast_ari_stop_playback_cb( } else {} } - ast_ari_stop_playback(headers, &args, response); + ast_ari_playback_stop(headers, &args, response); #if defined(AST_DEVMODE) code = response->response_code; @@ -172,11 +172,11 @@ fin: __attribute__((unused)) * \param headers HTTP headers. * \param[out] response Response to the HTTP request. */ -static void ast_ari_control_playback_cb( +static void ast_ari_playback_control_cb( struct ast_variable *get_params, struct ast_variable *path_vars, struct ast_variable *headers, struct ast_ari_response *response) { - struct ast_control_playback_args args = {}; + struct ast_ari_playback_control_args args = {}; struct ast_variable *i; #if defined(AST_DEVMODE) int is_valid; @@ -195,7 +195,7 @@ static void ast_ari_control_playback_cb( } else {} } - ast_ari_control_playback(headers, &args, response); + ast_ari_playback_control(headers, &args, response); #if defined(AST_DEVMODE) code = response->response_code; @@ -235,7 +235,7 @@ fin: __attribute__((unused)) static struct stasis_rest_handlers playback_playbackId_control = { .path_segment = "control", .callbacks = { - [AST_HTTP_POST] = ast_ari_control_playback_cb, + [AST_HTTP_POST] = ast_ari_playback_control_cb, }, .num_children = 0, .children = { } @@ -245,8 +245,8 @@ static struct stasis_rest_handlers playback_playbackId = { .path_segment = "playbackId", .is_wildcard = 1, .callbacks = { - [AST_HTTP_GET] = ast_ari_get_playback_cb, - [AST_HTTP_DELETE] = ast_ari_stop_playback_cb, + [AST_HTTP_GET] = ast_ari_playback_get_cb, + [AST_HTTP_DELETE] = ast_ari_playback_stop_cb, }, .num_children = 1, .children = { &playback_playbackId_control, } |