summaryrefslogtreecommitdiff
path: root/res/res_fax.c
diff options
context:
space:
mode:
authorCorey Farrell <git@cfware.com>2014-10-14 16:46:06 +0000
committerCorey Farrell <git@cfware.com>2014-10-14 16:46:06 +0000
commitc0943cf8d6bed1bcc589cc698108da9f358bbf3d (patch)
tree700a31587f98ed13922d934951fc32654d190b36 /res/res_fax.c
parent9a7fb8ee6cc7774a4ed5910eba443847ca7605b7 (diff)
res_fax: Fix reference leak caused by gateway sessions
Fax gateway session objects can be re-used, causing the same gateway session to be added to faxregistry.container more than once. This change causes fax_session_new to remove the reserved session from the container before it's id is changed, ensuring it's possible for the session to be freed. ASTERISK-24392 #close Reported by: Corey Farrell Review: https://reviewboard.asterisk.org/r/4049/ ........ Merged revisions 425457 from http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged revisions 425458 from http://svn.asterisk.org/svn/asterisk/branches/12 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/13@425459 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'res/res_fax.c')
-rw-r--r--res/res_fax.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/res/res_fax.c b/res/res_fax.c
index aef6360ff..01228c175 100644
--- a/res/res_fax.c
+++ b/res/res_fax.c
@@ -1216,6 +1216,7 @@ static struct ast_fax_session *fax_session_new(struct ast_fax_session_details *d
if (reserved) {
s = reserved;
ao2_ref(reserved, +1);
+ ao2_unlink(faxregistry.container, reserved);
/* NOTE: we don't consume the reference to the reserved
* session. The session returned from fax_session_new() is a