diff options
author | Kevin Harwell <kharwell@digium.com> | 2016-05-03 15:31:19 -0500 |
---|---|---|
committer | Kevin Harwell <kharwell@digium.com> | 2016-05-11 11:41:39 -0500 |
commit | 1b5c91b7be1020754ca724e488c9fb733dbce99d (patch) | |
tree | 11af06f227405cb8d7c9d4f5073295fcbde19050 /res/res_pjsip_outbound_publish.c | |
parent | 81773ceb9cb03e11b9a39fb882dcc72815784566 (diff) |
res_pjsip_outbound_publish: Potential crash due to off nominal path
It was possible for the explicit publish destroy function to be called without
the pjsip client ever being initialized. This fix checks to make sure there is
a client to destroy before attempting.
Change-Id: I8eea1bfa3bd472149bfc255310be2a6248688f5c
Diffstat (limited to 'res/res_pjsip_outbound_publish.c')
-rw-r--r-- | res/res_pjsip_outbound_publish.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/res/res_pjsip_outbound_publish.c b/res/res_pjsip_outbound_publish.c index 60f9bbb17..bf933cb32 100644 --- a/res/res_pjsip_outbound_publish.c +++ b/res/res_pjsip_outbound_publish.c @@ -687,8 +687,15 @@ static int explicit_publish_destroy(void *data) { struct ast_sip_outbound_publish_client *client = data; - pjsip_publishc_destroy(client->client); - ao2_ref(client, -1); + /* + * If there is no pjsip publishing client then we obviously don't need + * to destroy it. Also, the ref for the Asterisk publishing client that + * pjsip had would not exist or should already be gone as well. + */ + if (client->client) { + pjsip_publishc_destroy(client->client); + ao2_ref(client, -1); + } return 0; } |