diff options
author | Kinsey Moore <kmoore@digium.com> | 2014-08-27 15:31:35 +0000 |
---|---|---|
committer | Kinsey Moore <kmoore@digium.com> | 2014-08-27 15:31:35 +0000 |
commit | a4a58c2771928ac6e2cd0ca1e1f41c28b901fa13 (patch) | |
tree | c018eecb1ac01938f91e701bdfff44215a09b9b3 /tests/test_callerid.c | |
parent | e985cb076d22a2434d016707e674afbc48957a4c (diff) |
CallerID: Fix parsing of malformed callerid
This allows the callerid parsing function to handle malformed input
strings and strings containing escaped and unescaped double quotes.
This also adds a unittest to cover many of the cases where the parsing
algorithm previously failed.
Review: https://reviewboard.asterisk.org/r/3923/
Review: https://reviewboard.asterisk.org/r/3933/
........
Merged revisions 422112 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........
Merged revisions 422113 from http://svn.asterisk.org/svn/asterisk/branches/11
........
Merged revisions 422114 from http://svn.asterisk.org/svn/asterisk/branches/12
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/13@422154 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'tests/test_callerid.c')
-rw-r--r-- | tests/test_callerid.c | 165 |
1 files changed, 165 insertions, 0 deletions
diff --git a/tests/test_callerid.c b/tests/test_callerid.c new file mode 100644 index 000000000..43b760d89 --- /dev/null +++ b/tests/test_callerid.c @@ -0,0 +1,165 @@ +/* + * Asterisk -- An open source telephony toolkit. + * + * Copyright (C) 2014, Kinsey Moore + * + * Kinsey Moore <kmoore@digium.com> + * + * See http://www.asterisk.org for more information about + * the Asterisk project. Please do not directly contact + * any of the maintainers of this project for assistance; + * the project provides a web site, mailing lists and IRC + * channels for your use. + * + * This program is free software, distributed under the terms of + * the GNU General Public License Version 2. See the LICENSE file + * at the top of the source tree. + */ + +/*! + * \file + * \brief Callerid Tests + * + * \author\verbatim Kinsey Moore <kmoore@digium.com> \endverbatim + * + * This is an Asterisk test module for callerid functionality + * \ingroup tests + */ + +/*** MODULEINFO + <depend>TEST_FRAMEWORK</depend> + <support_level>core</support_level> + ***/ + +#include "asterisk.h" +#include "asterisk/callerid.h" + +ASTERISK_FILE_VERSION(__FILE__, "$Revision$") + +#include "asterisk/utils.h" +#include "asterisk/module.h" +#include "asterisk/test.h" + +struct cid_set { + char *cid; + char *name; + char *number; +}; + +AST_TEST_DEFINE(parse_nominal) +{ + static const struct cid_set cid_sets[] = { + {"\"name\" <number>", "name", "number"}, + {"\" name \" <number>", " name ", "number"}, + {"name <number>", "name", "number"}, + {" name <number>", "name", "number"}, + {"\"\" <number>", NULL, "number"}, + {"<number>", NULL, "number"}, + {"name", "name", NULL}, + {"\"name\"", "name", NULL}, + {"\"name\" <>", "name", NULL}, + {"name <>", "name", NULL}, + {"1234", NULL, "1234"}, + {"\"na\\\"me\" <number>", "na\"me", "number"}, + }; + char *name; + char *number; + int i; + + switch (cmd) { + case TEST_INIT: + info->name = "parse_nominal"; + info->category = "/main/callerid/"; + info->summary = "Callerid nominal parse unit test"; + info->description = + "This tests parsing of nominal callerid strings."; + return AST_TEST_NOT_RUN; + case TEST_EXECUTE: + break; + } + + for (i = 0; i < ARRAY_LEN(cid_sets); i++) { + RAII_VAR(char *, callerid, ast_strdup(cid_sets[i].cid), ast_free); + + ast_callerid_parse(callerid, &name, &number); + if (!cid_sets[i].name == !ast_strlen_zero(name) || (cid_sets[i].name && strcmp(name, cid_sets[i].name))) { + ast_test_status_update(test, + "Expected callerid name '%s' instead of '%s'\n", + cid_sets[i].name, name); + return AST_TEST_FAIL; + } + + if (!cid_sets[i].number == !ast_strlen_zero(number) || (cid_sets[i].number && strcmp(number, cid_sets[i].number))) { + ast_test_status_update(test, + "Expected callerid number '%s' instead of '%s'\n", + cid_sets[i].number, number); + return AST_TEST_FAIL; + } + } + + return AST_TEST_PASS; +} + +AST_TEST_DEFINE(parse_off_nominal) +{ + static const struct cid_set cid_sets[] = { + {"na\\\"me <number>", "na\"me", "number"}, + {"\"na\"me\" <number>", "na\"me", "number"}, + {"na\"me <number>", "na\"me", "number"}, + {"\"name <number>", "\"name", "number"}, + {"name <number", "name", "number"}, + {"\"name <number>\"", "name", "number"}, + }; + char *name; + char *number; + int i; + + switch (cmd) { + case TEST_INIT: + info->name = "parse_off_nominal"; + info->category = "/main/callerid/"; + info->summary = "Callerid off-nominal parse unit test"; + info->description = + "This tests parsing of off-nominal callerid strings."; + return AST_TEST_NOT_RUN; + case TEST_EXECUTE: + break; + } + + for (i = 0; i < ARRAY_LEN(cid_sets); i++) { + RAII_VAR(char *, callerid, ast_strdup(cid_sets[i].cid), ast_free); + + ast_callerid_parse(callerid, &name, &number); + if (!cid_sets[i].name == !ast_strlen_zero(name) || (cid_sets[i].name && strcmp(name, cid_sets[i].name))) { + ast_test_status_update(test, + "Expected callerid name '%s' instead of '%s'\n", + cid_sets[i].name, name); + return AST_TEST_FAIL; + } + + if (!cid_sets[i].number == !ast_strlen_zero(number) || (cid_sets[i].number && strcmp(number, cid_sets[i].number))) { + ast_test_status_update(test, + "Expected callerid number '%s' instead of '%s'\n", + cid_sets[i].number, number); + return AST_TEST_FAIL; + } + } + + return AST_TEST_PASS; +} + +static int unload_module(void) +{ + AST_TEST_UNREGISTER(parse_nominal); + AST_TEST_UNREGISTER(parse_off_nominal); + return 0; +} + +static int load_module(void) +{ + AST_TEST_REGISTER(parse_nominal); + AST_TEST_REGISTER(parse_off_nominal); + return AST_MODULE_LOAD_SUCCESS; +} + +AST_MODULE_INFO_STANDARD(ASTERISK_GPL_KEY, "Callerid Parse Tests"); |