diff options
| author | Matthew Jordan <mjordan@digium.com> | 2014-01-03 21:13:30 +0000 |
|---|---|---|
| committer | Matthew Jordan <mjordan@digium.com> | 2014-01-03 21:13:30 +0000 |
| commit | c6df713da7c279723370a59bc13a459260a89a63 (patch) | |
| tree | d56c6bea6477b6b06286c21295eebac30bb6bf4e /tests/test_utils.c | |
| parent | bd4be333fbc484fa5a8bb39e0615fbeed8160777 (diff) | |
res_pjsip_authenticator_digest: Fix md5 hash buffer
An md5 hash is 32 bytes long. The char buffer must be at least 33 bytes to
avoid clobbering of the stack. This patch also fixes a potential clobbering
in test_utils.c.
Thanks to Andrew Nagy for reporting and testing this out in #asterisk-dev
Reported by: Andrew Nagy
Tested by: Andrew Nagy
........
Merged revisions 404843 from http://svn.asterisk.org/svn/asterisk/branches/12
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@404844 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'tests/test_utils.c')
| -rw-r--r-- | tests/test_utils.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/test_utils.c b/tests/test_utils.c index f956e5b27..9150fccf4 100644 --- a/tests/test_utils.c +++ b/tests/test_utils.c @@ -202,7 +202,7 @@ AST_TEST_DEFINE(md5_test) ast_test_status_update(test, "Testing MD5 ...\n"); for (i = 0; i < ARRAY_LEN(tests); i++) { - char md5_hash[32]; + char md5_hash[33]; ast_md5_hash(md5_hash, tests[i].input); if (strcasecmp(md5_hash, tests[i].expected_output)) { ast_test_status_update(test, |