diff options
Diffstat (limited to 'main/message.c')
| -rw-r--r-- | main/message.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/main/message.c b/main/message.c index f2c5f4ddb..edc54c8ea 100644 --- a/main/message.c +++ b/main/message.c @@ -522,12 +522,20 @@ int ast_msg_set_var(struct ast_msg *msg, const char *name, const char *value) const char *ast_msg_get_var(struct ast_msg *msg, const char *name) { struct msg_data *data; + const char *val = NULL; if (!(data = msg_data_find(msg->vars, name))) { return NULL; } - return data->value; + /* Yep, this definitely looks like val would be a dangling pointer + * after the ref count is decremented. As long as the message structure + * is used in a thread safe manner, this will not be the case though. + * The ast_msg holds a reference to this object in the msg->vars container. */ + val = data->value; + ao2_ref(data, -1); + + return val; } struct ast_msg_var_iterator { |