summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-11-06Messaging: Report error on failure to register tech or handler.Corey Farrell
Message tech and handler registrations use a vector which could fail to expand. If it does log and error and return error. Change-Id: I593a8de81a07fb0452e9b0efd5d4018b77bca6f4
2017-11-06format_cap: Fix leak on AST_VECTOR_APPEND error.Corey Farrell
format_cap_framed_init can fail on AST_VECTOR_APPEND. This should report failure to the caller and clean the newly allocated frame. Change-Id: Ica0661235bf09497bf23d844ceb01f21b41a55b0
2017-11-06stasis: Remove silly use of RAII_VAR in stasis_forward_all.Corey Farrell
Change-Id: I46de4c968d40144d5b049966304ff66c1469fb65
2017-11-06CLI: Remove unused internal command.Corey Farrell
The internal CLI command "_command complete" was last used by Asterisk 0.2.0. Since then we've been using "_command nummatches" and "_command matchesarray". Change-Id: I682fe1e21a24a3bb5bd04146e639f1c5866bcfce
2017-11-06stasis_bridges.c: Fix off-nominal json memory leaks.Richard Mudgett
Change-Id: Ib1181a36b317c86bff1ef2e44a17a0b1c73cfdc8
2017-11-06res_pjsip_pubsub: Ensure remote URI contains URI only.Joshua Colp
This change makes it so that any user of the pubsub API that requests the remote URI receives only the URI. Previously the entire string was returned, which could contain a display name. ASTERISK-27290 Change-Id: If1d0cd6630f0a264856d31d2a67933109187a017
2017-11-06stasis_channels.c: Remove a very silly RAII_VAR().Richard Mudgett
Change-Id: I28b458b3c1a442c4ef0be7b4986a95ea4149e14f
2017-11-06stasis/app.c: Optimize stasis_app_get_debug_by_name()Richard Mudgett
* Eliminate RAII_VAR() * Short circuit application name lookup if global debug enabled. Change-Id: I5f78b7bd6ca7fd2c3b07cbbe036c6a93b4681123
2017-11-06Fix ast_(v)asprintf() malloc failure usage conditions.Richard Mudgett
When (v)asprintf() fails, the state of the allocated buffer is undefined. The library had better not leave an allocated buffer as a result or no one will know to free it. The most likely way it can return failure is for an allocation failure. If the printf conversion fails then you actually have a threading problem which is much worse because another thread modified the parameter values. * Made __ast_asprintf()/__ast_vasprintf() set the returned buffer to NULL on failure. That is much more useful than either an uninitialized pointer or a pointer that has already been freed. Many uses won't have to check for failure to ensure that the buffer won't be double freed or prevent an attempt to free an uninitialized pointer. * stasis.c: Fixed memory leak in multi_object_blob_to_ami() allocated by ast_asprintf(). * ari/resource_bridges.c:ari_bridges_play_helper(): Remove assignment to the wrong thing which is now not needed even if assigning to the right thing. Change-Id: Ib5252fb8850ecf0f78ed0ee2ca0796bda7e91c23
2017-11-06Merge "install_prereq: Checkout of libSRTP 2.x." into 13Jenkins2
2017-11-06Merge "configure: Add autoconf check for libopusfile." into 13Jenkins2
2017-11-06Merge "Prevent unload of modules which implement an Optional API." into 13Jenkins2
2017-11-06Merge "Add missing menuselect dependencies." into 13Jenkins2
2017-11-06Merge "Stasis/ARI: Fix off-nominal path json memory leaks." into 13Joshua Colp
2017-11-06res_pjsip: Ignore empty TLS configurationSean Bright
When using realtime, fields that are not explicitly set by an administrator are still presented to sorcery as empty strings. Handle this case explicitly. In this particular case, if any of these fields are required for TLS support, their existence should be validated in the 'apply' handler once we have a complete transport definition. ASTERISK-27032 #close Reported by: seanchann.zhou Change-Id: Ie3b5fb421977ccdb33e415d4ec52c3fd192601b7
2017-11-06Merge "AOC: Fix AOC-S json memory leak." into 13Jenkins2
2017-11-06Merge "res_stasis_mailbox.c: Fix leak of mailbox container." into 13Jenkins2
2017-11-06Merge "Build System: Fix build failure caused by recent CLI improvements." ↵Jenkins2
into 13
2017-11-06tcptls: Print notice when TLS is enabled but not configured.Alexander Traud
Asterisk can be compiled without a SSL/TLS library, without the Development Headers of OpenSSL. However, if TLS (SIP) or Secure-WebSockets (WebRTC) was enabled in a configuration file, Asterisk did not notice the user. Asterisk failed silently, only the corresponding TCP ports were not open. ASTERISK-27394 Reported-by: mossley74 Change-Id: Ib8b7539a5b2af8154c22e5f7a40fc68f95d95b93
2017-11-06configure: Add autoconf check for libopusfile.Corey Farrell
This check is being added to make it easier for end-users of third party open source Opus modules. This was removed by ASTERISK-26426 but only the module needed to be removed. Change-Id: I62b9cd0c4fa8a77596ab0e042948a643a1152677
2017-11-04install_prereq: Checkout of libSRTP 2.x.Alexander Traud
Since Asterisk 13.17, libSRTP 2.x is supported. Therefore, its latest version is installed again via the script install_prereq. ASTERISK-27356 Change-Id: I13125839a79052356469e41edacbebff0a937d39
2017-11-03Stasis/ARI: Fix off-nominal path json memory leaks.Richard Mudgett
Change-Id: Id569c624c426e3b22a99936473c730592d8b83fb
2017-11-03AOC: Fix AOC-S json memory leak.Richard Mudgett
Change-Id: I3a1d40a41a8a7d00fa4a187de6a343a79155d3ef
2017-11-03res_stasis_device_state.c: Optimize stasis_app_device_states_to_json()Richard Mudgett
* Eliminate RAII_VAR() * Replace looped alloca with a char[] since that is how it is used anyway. Change-Id: Ia27e64a884afa0f50b9ffdb1cf23da6bfa51ffdf
2017-11-03res_stasis_mailbox.c: Fix leak of mailbox container.Richard Mudgett
Change-Id: I7d33c1635713047e7d1597c9d882f7dc006d94b4
2017-11-03Build System: Fix build failure caused by recent CLI improvements.Corey Farrell
We use the editline library to help with filename completion in our CLI interface. Some systems failed to find the header when included from loader.c. This is fixed by setting the proper CFLAGS for the build of loader.o. ASTERISK-27378 Change-Id: Ib7fd496f1d7ed48141a2eadd5dd61cab2f2308be
2017-11-03Merge "res_pjsip: Add to list of valid characters for from_user." into 13Joshua Colp
2017-11-03Merge "Modules: Additional improvements to CLI completion." into 13Jenkins2
2017-11-02res_pjsip: Add to list of valid characters for from_user.Ben Ford
Fixes a regression where some characters were unable to be used in the from_user field of an endpoint. Additionally, the backtick was removed from the list of valid characters, since it is not valid, and it was replaced with a single quote, which is a valid character. ASTERISK-27387 Change-Id: Id80c10a644508365c87b3182e99ea49da11b0281
2017-11-02Modules: Additional improvements to CLI completion.Corey Farrell
Replace 'needsreload' argument with a 'type' argument to specify which type of modules you want completion. This provides more accurate CLI completion for load and unload commands. * 'module unload' now excludes modules that have active references or are not running. * 'module load' now excludes modules that are already running. * 'core set debug [atleast] <level> [module]' shows running modules only. ASTERISK-27378 Change-Id: Iea3e00054461484196c46f688f02635cc886bad1
2017-11-02Add missing menuselect dependencies.Corey Farrell
This adds menuselect dependencies for modules that use symbols of other modules. ASTERISK-27390 Change-Id: Ia2d2849f5b87a72af7324a82edc3f283eafb5385
2017-11-01Prevent unload of modules which implement an Optional API.Corey Farrell
Once an Optional API module is loaded it should stay loaded. Unloading an optional API module runs the risk of a crash if something else is using it. This patch causes all optional API providers to tell the module loader not to unload except at shutdown. ASTERISK-27389 Change-Id: Ia07786fe655681aec49cc8d3d96e06483b11f5e6
2017-11-01pjsip_message_filter: Only do interface lookup for wildcard addresses.Sean Bright
Change-Id: Ie083987e69dc43b6861671c218cacacc11b2072f
2017-10-31features: Bridge application's BRIDGERESULT not appropriately setKevin Harwell
The dialplan application "Bridge" was not setting the BRIDGERESULT to failure when a failure did occur. Even worse if it did fail to join the bridge it would still report success. This patch now sets the BRIDGERESULT variable to an appropriate value for a given condition state. Also, removed the value INCOMPATIBLE as a valid result type since it is no longer used. ASTERISK-27369 #close Change-Id: I22588e7125a765edf35cff28c98ca143e9927554
2017-10-31Merge "ast_coredumper: allow setting asterisk binary explicitly" into 13Jenkins2
2017-10-31Merge "Build System: Fix --disable-xmldoc option." into 13Jenkins2
2017-10-30Merge "Modules: Fix issues with CLI completion." into 13Jenkins2
2017-10-30Merge "app_agent_spool: Fix typo in dtmf features usage desctiption" into 13Jenkins2
2017-10-30Merge "ast_coredumper: Add gzipping of binaries and display of signal info" ↵Jenkins2
into 13
2017-10-30ast_coredumper: allow setting asterisk binary explicitlyTzafrir Cohen
Adds an extra option, --asterisk-bin=<path> to ast_coredumper. If provided, the binary given to gdb will be the parameter, rather than asterisk from the PATH. ASTERISK-27380 #close Change-Id: I25f5b91eb75059b0fb2f142e468c26b283b0a9f3
2017-10-30Modules: Fix issues with CLI completion.Corey Farrell
* Stop using ast_module_helper to check if a module is loaded, use ast_module_check instead (app_confbridge and app_meetme). * Stop ast_module_helper from listing reload classes when needsreload was not requested. ASTERISK-27378 Change-Id: Iaed8c1e4fcbeb242921dbac7929a0fe75ff4b239
2017-10-29app_agent_spool: Fix typo in dtmf features usage desctiptionIgor Goncharovskiy
Fix typo, that specify usage wrong option 'dtmf-features' for CHANNEL() function instead of correct 'dtmf_features' ASTERISK-27377 #close Change-Id: I15ecc829c1035b359584673e12cdb5c9291ac930
2017-10-27res_pjsip_pubsub: Resolve potential crash in allocate_subscription.Corey Farrell
When allocate_subscription fails to initialize fields of the new sub it calls destroy_subscription. Change-Id: I5b79c915ec216dc00c13c1e4172137864a4bec85
2017-10-27Merge "codec.c: Defensively check the returned samples." into 13Joshua Colp
2017-10-27Merge "app_voicemail.c: Fix compiler warning with IMAP build." into 13Jenkins2
2017-10-26Merge "res_pjsip: Add 'ip' as a valid option to 'identify_by' on endpoint." ↵Joshua Colp
into 13
2017-10-26app_voicemail.c: Fix compiler warning with IMAP build.Richard Mudgett
ASTERISK-27181 Change-Id: Ic4468b49860bd7f67e922baf4c9e96828c184d17
2017-10-26codec.c: Defensively check the returned samples.Richard Mudgett
Earlier versions of the codec_opus samples_count callback can return negative error values on undecodable frames. This resulted in a divide by zero exception. * Added a defensive check in ast_codec_samples_count() for a "negative" samples count return value. Log the event and set the count to zero. ASTERISK-27194 Change-Id: Icf69350307ecbbc80a3d74de46af9bd80ea17819
2017-10-25res_pjsip: Add 'ip' as a valid option to 'identify_by' on endpoint.Joshua Colp
When the identify_by option on an endpoint is set to ip it will only be identified using the res_pjsip_endpoint_identifier_ip module. This ensures that it is not mistakenly matched using the username of the From header. To ensure behavior has not changed the default has been changed to "username,ip" for the identify_by option. ASTERISK-27206 Change-Id: I2170b86a7f7e221b4f00bf14aa1ef1ac5b050bbd
2017-10-25Merge "http.c: Fix http header send content." into 13Joshua Colp
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-08 16:24:01 +0000