summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-11-21Merge "cli: Remove silly usage of RAII_VAR." into 15Joshua Colp
2017-11-21Merge "loader: Fix comments in struct ast_module." into 15Joshua Colp
2017-11-21Merge "menuselect: Remove ineffective weak attribute detection." into 15Joshua Colp
2017-11-21Merge "README: Send people to secure websites where available." into 15Joshua Colp
2017-11-21Merge "Build: Fix issues building without SSL." into 15Joshua Colp
2017-11-21Merge "Build: Fix OSX build issues." into 15Joshua Colp
2017-11-20loader: Fix comments in struct ast_module.Corey Farrell
Make the comments follow doxygen format, move comments to the line before each field they describe. Change-Id: Ic445468398b5e88f13910f7c2f70bd15aad33a27
2017-11-20Merge "res_pjsip: Use sorcery prefix operation for contact lookup" into 15Joshua Colp
2017-11-20Merge "CLI: Create ast_cli_completion_vector." into 15Joshua Colp
2017-11-20Merge "acl: Fix allocation related issues." into 15Joshua Colp
2017-11-20Merge "bridge_basic: Ignore answer from transfer target when they've timed ↵Joshua Colp
out." into 15
2017-11-20cli: Remove silly usage of RAII_VAR.Corey Farrell
Change-Id: I81aacfee7cd26e4fc5eef07bca582700c2975bd7
2017-11-20Merge "doxygen: Remove obsolete contents." into 15Joshua Colp
2017-11-20Merge "res_fax: Remove checks for unsigned values being >= 0." into 15Joshua Colp
2017-11-20Merge "res_snmp: Declare RONLY if net-snmp headers do not." into 15Joshua Colp
2017-11-20Merge "iostream: Fix ast_iostream_printf declaration." into 15Joshua Colp
2017-11-20Merge "tests: Fix warnings found on Mac." into 15Joshua Colp
2017-11-20Merge "app_minivm: Fix possible uninitialized return value." into 15Joshua Colp
2017-11-20Merge "res_pjsip: Fix warning by deferring implicit type cast." into 15Joshua Colp
2017-11-19Build: Fix OSX build issues.Corey Farrell
OSX does not support 'readlink -f' or 'sed -r'. Replace readlink with the GNU make macro 'realpath'. Replace sed with grep in one place, cut in the other. ASTERISK-27332 Change-Id: I5d34ecca905384decb22ead45c913ae5e8aff748
2017-11-19Build: Fix issues building without SSL.Corey Farrell
* Fix conditional in libasteriskssl. * Use variables produced by configure to link the SSL and uuid libraries into libasteriskpj.so instead of hard-coding them. ASTERISK-27431 Change-Id: I3977931fd3ef8c4e4376349ccddb354eb839b58d
2017-11-19res_pjsip: Fix warning by deferring implicit type cast.Corey Farrell
Mac doesn't like the comparison of -1 to an enum, so store the result of ast_sip_str_to_dtmf to an int so we can check for the negative return value. ast_sip_str_to_dtmf returns an int so this is only delaying the implicit type cast. Change-Id: I0c262c1719ee951aae1f437d733a301cf5f8ad29
2017-11-18tests: Fix warnings found on Mac.Corey Farrell
test_pbx used raise without explicitly including signal.h. On Mac for some reason nothing else includes it. test_logger checked if an unsigned int was negative. Switch the variable to 'int' so that error check can be effective. Change-Id: Ie1db5dd1818ac25cc2ae41b644f848b5865b1362
2017-11-18res_snmp: Declare RONLY if net-snmp headers do not.Corey Farrell
Some net-snmp builds do not provide the RONLY declare, only NETSNMP_OLDAPI_RONLY. Map RONLY to NETSNMP_OLDAPI_RONLY to get around this error. Change-Id: Ida5c7ad9406515825485c4d3b4a34fd6ad0da577
2017-11-18res_fax: Remove checks for unsigned values being >= 0.Corey Farrell
It's impossible for gwtimeout or fdtimeout to be less than 0 because they are unsigned int's. Remove checks and unreachable branches. Change-Id: Ib2286960621e6ee245e40013c84986143302bc78
2017-11-18iostream: Fix ast_iostream_printf declaration.Corey Farrell
This adds the printf attribute and changes 'fmt' from 'const void *' to 'const char *'. This resolves a warning from some compiler for vsnprintf needing a literal string for format. Change-Id: I71c33a8262590042ee451e1146760c10bb22fb78
2017-11-18app_minivm: Fix possible uninitialized return value.Corey Farrell
Declare 'res' initialized to -1 to deal with earlier error paths that could cause 'res' to be returned uninitialized. Change-Id: I8ac2a5755bf4174d89ef893e924c940f702b104e
2017-11-17README: Send people to secure websites where available.Corey Farrell
We should be sending people to secure web URL's where available. Update README's and docs. Change-Id: Id5b1e049b0b18b49a784f1254605aefa244ce19a
2017-11-17doxygen: Remove obsolete contents.Corey Farrell
Remove doxygen contents that have nothing to do with the current state of Asterisk. Change-Id: Ic072cc8641f9533a202990ccf275ce87e3efd95c
2017-11-17res_pjsip: Use reasonable buffer lengths for endpoint identificationSean Bright
Domains themselves can be up to 255 characters long (per RFC 1035), so our current buffer sizes are wholly inadequate for many use cases. Change-Id: If3f30a68307f1365a1fe06bc4b854c62842c9292
2017-11-17menuselect: Remove ineffective weak attribute detection.Corey Farrell
menuselect detects compiler support for multiple styles of weak functions. This is a remnant from 2013 when OPTIONAL_API required weak functions. It is no longer correct for menuselect to switch dependencies from optional to required based on lack of weak function support. Note an issue remains - dependencies should switch from optional to required based on OPTIONAL_API being enabled or disabled. I don't think this is possible. menuselect needs to know at startup if OPTIONAL_API is enabled or disabled, so the only way to fix this is to remove OPTIONAL_API from menuselect and create a configure option. I've left the code that switches in place but it's preprocessed out. Additionally removed: - WEAKREF variable from Asterisk makeopts.in. - Related disabled code from test_utils. - Pointless AC_REVISION call from menuselect/configure.ac. Change-Id: Ifa702e5f98eb45f338b2f131a93354632a8fb389
2017-11-17Merge "Build: Make function constructor/destructor attributes mandatory." ↵Jenkins2
into 15
2017-11-17acl: Fix allocation related issues.Corey Farrell
Add checks for allocation errors, cleanup and report failure when they occur. * ast_duplicate_acl_list: Replace log warnings with errors, add missing line-feed. * ast_append_acl: Add missing line-feed to logger message. * ast_append_ha: Avoid ast_strdupa in loop by moving debug message to separate function. * ast_ha_join: Use two separate calls to ast_str_append to avoid using ast_strdupa in a loop. Change-Id: Ia19eaaeb0b139ff7ce7b971c7550e85c8b78ab76
2017-11-17CLI: Create ast_cli_completion_vector.Corey Farrell
This is a rewrite of ast_cli_completion_matches using a vector to build the list. The original function calls the vector version, NULL terminates the vector and extracts the elements array. One change in behavior the results are now sorted and deduplicated. This will solve bugs where some duplicate checking was done before the list was sorted. Change-Id: Iede20c5b4d965fa5ec71fda136ce9425eeb69519
2017-11-17Merge "aoc: Fix memory management issues." into 15Jenkins2
2017-11-17bridge_basic: Ignore answer from transfer target when they've timed out.Joshua Colp
This is a fun one. Given the following attended transfer scenario: 1. Transfer target is called 2. Transferer hangs up 3. Transfer target call attempt reaches timeout 4. Transfer target is told to hang up 5. Transfer target answers before channel is hung up 6. Transferer recall target is called A crash would occur. This is because the transfer target call attempt, despite being told to hang up, would raise a recall target answer before the recall target had been answered. As it had not answered there would be no recall target channel and it would implode. This change makes it so that if the transfer target has been hung up we don't tell the attended transfer code that it has answered. We also clear out the stimulus that the recall target has been answered after telling the transfer target to hang up, in case it was able to raise the information before we told it to hangup. ASTERISK-27361 Change-Id: Ifb8b255a9c4d2c5c1b8ad77bf54f659ed286df99
2017-11-16aoc: Fix memory management issues.Corey Farrell
aoc_publish_blob failed to check for msg allocation error and never released msg. Change-Id: Ib31a9ffb81056a0d496a49d7eec795005a44bcd5
2017-11-16res_pjsip_transport_websocket: Give transport a meaningful descriptionSean Bright
We were not \0 terminating this string, so any attempt to print it would in the best case show an empty string and in the worst case potentially crash. Change-Id: I63d96ef8f7516ac02a0f91e22dfa8acdc615042c
2017-11-16res_pjsip: Use sorcery prefix operation for contact lookupSean Bright
This improves performance for registrations assuming that res_config_astdb is not in use. Change-Id: I86f37aa9ef07a4fe63448cb881bbadd996834bb1
2017-11-16Merge "ast_coredumper: Add ability to use directory other than /tmp" into 15Joshua Colp
2017-11-16Merge "pjsip / hep: Provide correct local address for Websockets." into 15Jenkins2
2017-11-16Merge "sorcery: Add ast_sorcery_retrieve_by_prefix()" into 15Jenkins2
2017-11-16Merge "chan_pjsip.c: Improve answer failure log messages." into 15Jenkins2
2017-11-16Merge "audiohook.c: Fix freeing a frame and still using it." into 15Joshua Colp
2017-11-15chan_pjsip.c: Improve answer failure log messages.Richard Mudgett
* Balanced the session->inv_session refs on answer failure. Change-Id: I33542d639d37e692cb46550b972a5fcfc3b804b8
2017-11-15audiohook.c: Fix freeing a frame and still using it.Richard Mudgett
Memory corruption happened to the media frame caches when an audio hook freed a frame when it shouldn't. I think the freed frame was because a jitter buffer interpolated a missing frame and the audio hook unconditionally freed it. * Made audiohook.c:audio_audiohook_write_list() not free an interpolated frame if it is the same frame as what was passed into the routine. * Made plc.c:normalise_history() use memmove() instead of memcpy() on a memory block that could overlap. Found by valgrind investigating this issue. ASTERISK-27238 ASTERISK-27412 Change-Id: I548d86894281fc4529aefeb9f161f2131ecc6fde
2017-11-15app_record: Don't set RECORD_STATUS chan var until file is closedGeorge Joseph
We've been calling pbx_builtin_setvar_helper to set the RECORD_STATUS variable before actually closing the recorded file. If a client is watching VarSet events and tries to do something with the file when a RECORD_STATUS event is seen, they might attempt to do so while the file it's still open. We now delay calling pbx_builtin_setvar_helper until after we close the file. ASTERISK-27423 Change-Id: I7fe9de99953e46b4bafa2b38cf151fe8f6488254
2017-11-15ast_coredumper: Add ability to use directory other than /tmpGeorge Joseph
The OUTPUTDIR environment variable can now be set either in the environment itself or in ast_debug_tools.conf. If set, it's used for all work products instead of /tmp. Also added the --tarball-config option that includes the contents of /etc/asterisk when either --tarball-coredumps or --tarball-results are used. Change-Id: I66b2553319df61caea5b313d084f51978f730b4c
2017-11-14Merge "bundled_pjproject: Update to 2.7.1" into 15Joshua Colp
2017-11-14Merge "bundled_pjproject: sip_parser: Fix return code in pjsip_find_msg" ↵Joshua Colp
into 15
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-03 08:31:30 +0000