summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-10-09Merge "res_pjsip: Fix issues that prevented shutdown of modules." into 15Jenkins2
2017-10-09Merge "cdr.c: Replace redundant check with an ast_assert()" into 15Jenkins2
2017-10-09Merge "cdr.h: Fix doxygen comments." into 15Joshua Colp
2017-10-09Merge "cdr.c: Use current ao2 flag names" into 15Jenkins2
2017-10-09Merge "cdr.c: Replace inlined code with ao2_t_replace()" into 15Jenkins2
2017-10-09Merge "res_config_sqlite: Don't enable SQLite CDRs when running 'make ↵Joshua Colp
samples'" into 15
2017-10-09Merge "res_pjsip_session: Fix format_cap leak." into 15Jenkins2
2017-10-09Merge "res_pjsip: Fix leak of persistent endpoint references." into 15Jenkins2
2017-10-09cdr.c: Replace redundant check with an ast_assert()Richard Mudgett
The only caller of cdr_object_fn_table.process_party_b() explicitly does the check before calling. Change-Id: Ib0c53cdf5048227842846e0df9d2c19117c45618
2017-10-09cdr.c: Replace inlined code with ao2_t_replace()Richard Mudgett
Change-Id: I9f424f5282ca7d833592f958d95f1b2bafb549b0
2017-10-09cdr.c: Use current ao2 flag namesRichard Mudgett
Change-Id: Ib59d7d2f2a4a822754628f2c48a308d6791a6e6e
2017-10-09cdr.h: Fix doxygen comments.Richard Mudgett
* Also some misc formatting in cdr.c. Change-Id: Ied89a28802a662c37c43326a1aafdce596e0df4a
2017-10-09Merge "res_sdp_translator_pjmedia: Fix test unregistration." into 15Joshua Colp
2017-10-09res_config_sqlite: Don't enable SQLite CDRs when running 'make samples'Sean Bright
Change-Id: I65a5190b2732b2246d67472db70dd37db64ddad4
2017-10-09res/res_ari.c Fix: Memory leaks in ARI when using Content-Type: application/jsonhajekd
ASTERISK-27305 Reported by: David Hajek Tested by: David Hajek Change-Id: Ife3e289062e6cf7d0e7d342dbf79ed96feff441e
2017-10-07res_pjsip_session: Fix format_cap leak.Corey Farrell
ASTERISK-27306 Change-Id: I2c8d3fc148f9f53715c958314e1146f9611741f3
2017-10-06res_pjsip: Fix leak of persistent endpoint references.Corey Farrell
Do not manually call sip_endpoint_apply_handler from load_all_endpoints. This is not necessary and causes memory leaks. Additionally reinitialize persistent->aors when we reuse a persistent object with a new endpoint. ASTERISK-27306 Change-Id: I59bbfc8da8a14d5f4af8c5bb1e71f8592ae823eb
2017-10-06Merge "vector: multiple evaluation of elem in AST_VECTOR_ADD_SORTED." into 15Jenkins2
2017-10-06Merge "main/strings: Fix uninitialized value." into 15George Joseph
2017-10-06Merge "res_pjsip: Fix leak of fake_auth references." into 15Jenkins2
2017-10-06vector: multiple evaluation of elem in AST_VECTOR_ADD_SORTED.Corey Farrell
Use temporary variable to prevent multiple evaluations of elem argument. This resolves a memory leak in res_pjproject startup. ASTERISK-27317 #close Change-Id: Ib960d7f5576f9e1a3c478ecb48995582a574e06d
2017-10-06res_sdp_translator_pjmedia: Fix test unregistration.Corey Farrell
ASTERISK-27306 Change-Id: Ib3ed47167cb697ab7bd0a56cab589893f491651b
2017-10-06res_pjsip: Fix leak of fake_auth references.Corey Farrell
pjsip_distributor leaks references to fake_auth when the default realm has not changed. ASTERISK-27306 Change-Id: I3fcf103b3680ad2d1d4610dcd6738eeaebf4d202
2017-10-05main/strings: Fix uninitialized value.Corey Farrell
ast_strings_match uses sscanf and checks for non-zero return to verify a token was parsed. This is incorrect as sscanf returns EOF (-1) for errors. ASTERISK-27318 #close Change-Id: Ifcece92605f58116eff24c5a0a3b0ee08b3c87b1
2017-10-05res_pjsip_caller_id chan_sip: Comply to RFC 3323 values for privacyDaniel Tryba
Currently privacy requests are only granted if the Privacy header value is exactly "id" (defined in RFC 3325). It ignores any other possible value (or a combination there of). This patch reverses the logic from testing for "id" to grant privacy, to testing for "none" and granting privacy for any other value. "none" must not be used in combination with any other value (RFC 3323 section 4.2). ASTERISK-27284 #close Change-Id: If438a21f31a962da32d7a33ff33bdeb1e776fe56
2017-10-05res_pjsip: Fix issues that prevented shutdown of modules.Corey Farrell
res_pjsip and res_pjsip_session had circular references, preventing both modules from shutting down. * Move session supplement registration to res_pjsip. * Use create internal functions for use by pjsip_message_filter.c. ASTERISK-27306 Change-Id: Ifbd5c19ec848010111afeab2436f9699da06ba6b
2017-10-04Merge "app_queue.c: Fix announcements when announce-to-first-user not ↵Jenkins2
enabled." into 15
2017-10-04res_calendar_icalendar: Filter out occurrences superceded by another VEVENTkrells
When we are loading the calendars, we call libical's icalcomponent_foreach_recurrence method for each VEVENT component that we have in our calendar. That method has no knowledge concerning the existence of the other VEVENT components and will feed our callback with all ocurrences matching the requested time span. The occurrences generated by icalcomponent_foreach_recurrence while expanding a recurring VEVENT's RRULE and RDATE properties can be superceded by an other VEVENT sharing the same UID. I use an external iterator (in libical terminology) to avoid messing with the internal ones from the calling function, and search for VEVENTS which could supersede the current occurrence. The event which can invalidate this occurence needs to have: - the same UID as our recurrent component (comp) - a RECURRENCE-ID property, which represents the start time of this occurrence If one component is found, just clean and return. ASTERISK-27296 #close Reported by: Benoît Dereck-Tricot Change-Id: I8587ae3eaa765af7cb21eda3b6bf84e8a1c87af8
2017-10-03Merge "heap.c: No need to calloc heap pointer array." into 15Jenkins2
2017-10-03Merge "logger: Bring back ability to turn debug on by source file" into 15Jenkins2
2017-09-28app_queue.c: Fix announcements when announce-to-first-user not enabled.Richard Mudgett
The previous patch for ASTERISK-27216 made it so you wouldn't get any position or periodic announcements unless you had announce-to-first-user enabled. The announce-to-first-user feature was added by ASTERISK_21782 as a result of the patch which introduced the redundant announcements that ASTERISK-27216 removes. * By noting that the makeannouncement variable is used to suppresses the first user announcement, we set its initial value to the announce-to-first-user enable setting. ASTERISK-27216 Change-Id: Ieaeb7dbea8ae7073086b775fbafe0625b000b10a
2017-09-28heap.c: No need to calloc heap pointer array.Richard Mudgett
Change-Id: I5ae2f316229f336eb90d99c7af7ed07a33097e68
2017-09-28Merge "pjsip_message_filter: Fix regression causing bad contact address" into 15Jenkins2
2017-09-28Merge "res_stasis: Add 'video_sfu' as a requested bridge type." into 15Jenkins2
2017-09-28Merge "res_pjsip_session: outgoing call did not offer all configured codecs" ↵Jenkins2
into 15
2017-09-28logger: Bring back ability to turn debug on by source fileGeorge Joseph
Somewhere along the way we lost the ability to debug individual source files. For modules, this wasn't a big deal but all the source files in ./main are in the one "core" module so debugging individual core capabilities was almost impossible. * Added a test to DEBUG_ATLEAST that also checks __FILE__ instead of just module name. Any source file will work even if it's in a module subdirectory. Change-Id: Icc0af41837f3b1679dec7af21fa32cd1f7469f6e
2017-09-28Merge "pjproject: Patch to correct STUN FINGERPRINT usage" into 15Joshua Colp
2017-09-28Merge "res_rtp_asterisk.c: Fix bridge_p2p_rtp_write() reentrancy potential." ↵Jenkins2
into 15
2017-09-28Merge "res_rtp_asterisk: Trim trailing byte off of SDES packet" into 15Joshua Colp
2017-09-28res_stasis: Add 'video_sfu' as a requested bridge type.Joshua Colp
This change adds 'video_sfu' as a requested bridge type when creating a bridge. By specifying this a mixing type bridge is created that exchanges video in an SFU fashion. Change-Id: I2ada47cf5f3fc176518b647c0b4aa39d55339606
2017-09-27res_pjsip_outbound_publish.c: Fix misplaced parenthesis.Richard Mudgett
The pjsip_publishc_init() call was referenced with a misplaced parentheses. As a result, outbound publication messages went out with an expiration of 1 second. ASTERISK-27298 Change-Id: I93622eabc8ee83e7a22e98c107f921284c605a08
2017-09-26pjsip_message_filter: Fix regression causing bad contact addressGeorge Joseph
The "res_pjsip: Filter out non SIP(S) requests" commit moved the filtering of messages to pjproject's PJSIP_MOD_PRIORITY_TRANSPORT_LAYER in order to filter out incoming bad uri schemes as early as possible. Since the change affected outgoing messages as well and the TRANSPORT layer is the last to be run on outgoing messages, we were overwriting the setting of external_signaling_address (which is set earlier by res_pjsip_nat) with an internal address. * pjsip_message_filter now registers itself as a pjproject module twice. Once in the TSX layer for the outgoing messages (as it was originally), then a second time in the TRANSPORT layer for the incoming messages to catch the invalid uri schemes. ASTERISK-27295 Reported by: Sean Bright Change-Id: I2c90190c43370f8a9d1c4693a19fd65840689c8c
2017-09-26res_rtp_asterisk.c: Fix bridge_p2p_rtp_write() reentrancy potential.Richard Mudgett
The bridge_p2p_rtp_write() has potential reentrancy problems. * Accessing the bridged RTP members must be done with the instance1 lock held. The DTMF and asymmetric codec checks must be split to be done with the correct RTP instance struct locked. i.e., They must be done when working on the appropriate side of the point to point bridge. * Forcing the RTP mark bit was referencing the wrong side of the point to point bridge. The set mark bit is used everywhere else to set the mark bit when sending not receiving. The patches for ASTERISK_26745 and ASTERISK_27158 did not take into account that not everything carried by RTP uses a codec. The telephony DTMF events are not exchanged with a codec. As a result when RFC2833/RFC4733 sent digits you would crash if "core set debug 1" is enabled, the DTMF digits would always get passed to the core even though the local native RTP bridge is active, and the DTMF digits would go out using the wrong SSRC id. * Add protection for non-format payload types like DTMF when updating the lastrxformat and lasttxformat. Also protect against non-format payload types when checking for asymmetric codecs. ASTERISK-27292 Change-Id: I6344ab7de21e26f84503c4d1fca1a41579364186
2017-09-26res_rtp_asterisk: Trim trailing byte off of SDES packetSean Bright
This could have been fixed by subtracting 1 from the final value of 'len' but the way the packet was being constructed was confusing so I took the opportunity to (I think) make it more clear. We were sending 1 extra byte at the end of the SDES RTCP packet which caused Chrome to complain (in its debug log): Too little data (1 byte) remaining in buffer to parse RTCP header (4 bytes). We now send the correct number of bytes. Change-Id: I9dcf087cdaf97da0374ae0acb7d379746a71e81b
2017-09-26Merge "webrtc: Allow 'webrtc' to be set on endpoints without dtls_ca_file" ↵Joshua Colp
into 15
2017-09-26Merge "channel.c: Fix invalid reference in conditionaled out code." into 15Joshua Colp
2017-09-26Merge "app_queue: Only do announcement logic between ringing cycles" into 15Jenkins2
2017-09-25Merge "res_pjsip_session: Reduce (and improve) SDP renegotiation." into 15Jenkins2
2017-09-25webrtc: Allow 'webrtc' to be set on endpoints without dtls_ca_fileSean Bright
If using a legitimate certificate from a trusted certificate authority, you don't need to provide CA file. Change-Id: I8623973b4209b44889243716d7880274caed8a6d
2017-09-25pjproject: Patch to correct STUN FINGERPRINT usageSean Bright
Change-Id: I0e453253dff1388b0186b36c754457c1d0d12db6