summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2008-04-05Found a little problem with the sip request handling that could lead to a ↵Steve Murphy
quick crash of asterisk, and a road to a DOS attack if left unfixed. Attaching to a running asterisk with "telnet hostname 5060", I would input "something", then hit return three times, and asterisk crashes. I traced it to handle_request_do(), which zeroes out the data (an ast_str ptr) if the string is too short. Instead of freeing the struct and nulling the pointer, it now just resets it, because this ast_str is expected by the calling routine to still be there after handle_request_do() returns. This appears to fix the crash. I assume that it was introduced with ast_str's being adopted. It's a subtle and easy-to-miss sort of problem. I also found all the places where the req.data is freed, and made sure the ptr is Nulled out as well; no good leaving bad ptrs laying around-- I didn't need to do this, but it seemed a good thing to do... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112874 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-04Merged revisions 112820 via svnmerge from Philippe Sultan
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r112820 | phsultan | 2008-04-04 21:26:15 +0200 (Fri, 04 Apr 2008) | 1 line Free newly allocated channel before returning ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112821 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-04Merged revisions 112766 via svnmerge from Philippe Sultan
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r112766 | phsultan | 2008-04-04 19:16:59 +0200 (Fri, 04 Apr 2008) | 7 lines Prevent call connections when codecs don't match. (closes issue #10604) Reported by: keepitcool Patches: branch-1.4-10604-2.diff uploaded by phsultan (license 73) Tested by: phsultan ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112785 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-04sleep long enough for the zaptel timer error message to display before exitDwayne M. Hubbard
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112714 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-04Merged revisions 112711 via svnmerge from Joshua Colp
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r112711 | file | 2008-04-03 21:52:36 -0300 (Thu, 03 Apr 2008) | 2 lines Pass in the path to Zaptel for systems that install Zaptel headers in a separate location. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112712 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-04Blocked revisions 112709 via svnmergeJoshua Colp
........ r112709 | file | 2008-04-03 21:48:01 -0300 (Thu, 03 Apr 2008) | 2 lines One thing at a time... let's get 1.4 building. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112710 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-04blocked for trunk....wootDwayne M. Hubbard
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112708 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-03satisfy buildbotDwayne M. Hubbard
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112656 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-03add a Zaptel timer check to verify the timer is responding when Zaptel ↵Dwayne M. Hubbard
support is compiled into Asterisk and Zaptel drivers are loaded. This will help people not waste their valuable time debugging side effects. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112653 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-03Merged revisions 112599 via svnmerge from Mark Michelson
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r112599 | mmichelson | 2008-04-03 09:32:20 -0500 (Thu, 03 Apr 2008) | 9 lines Fix the testing of the "res" variable so that it is more logically correct and makes the correct warning and debug messages print. (closes issue #12361) Reported by: one47 Patches: chan_zap_deferred_digit.patch uploaded by one47 (license 23) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112600 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-03Use a 32k file buffer on recordings, which increases the efficiency of file ↵Tilghman Lesher
recording. (closes issue #11962) Reported by: garlew Patches: recording.patch uploaded by garlew (license 376) bug-11962.diff uploaded by snuffy (license 35) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112564 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-02Make MISDN generate channel rename events when the name changes.Tilghman Lesher
(closes issue #11142) Reported by: julianjm Patches: chan_misdn_tmpchan_trunk_v1.diff uploaded by julianjm (license 99) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112520 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-02Merged revisions 112468 via svnmerge from Mark Michelson
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r112468 | mmichelson | 2008-04-02 12:36:04 -0500 (Wed, 02 Apr 2008) | 13 lines Fix a race condition in the manager. It is possible that a new manager event could be appended during a brief time when the manager is not waiting for input. If an event comes during this period, we need to set an indicator that there is an event pending so that the manager doesn't attempt to wait forever for an event that already happened. (closes issue #12354) Reported by: bamby Patches: manager_race_condition.diff uploaded by bamby (license 430) (comments added by me) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112469 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-02Since the SIP request structure gets reused multiple times with TCP handling ↵Joshua Colp
we have to clear the debug state or else we will keep spitting out debug even after it has been turned off. (closes issue #12169) Reported by: pj Patches: 12169-debugoff-2.diff uploaded by qwell (license 4) Tested by: pj git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112431 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-02Re-add HTTP post support by moving to res_http_post.cTerry Wilson
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112426 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-02Merged revisions 112393 via svnmerge from Mark Michelson
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r112393 | mmichelson | 2008-04-02 09:32:00 -0500 (Wed, 02 Apr 2008) | 6 lines Ensure that there is no timeout if none is specified. (closes issue #12349) Reported by: johnlange ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112394 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01Added dnsmgr status output for sip show registry.Jeff Peeler
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112360 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01Bumped across another test set for the new exten pattern matcher, which ↵Steve Murphy
revealed a problem with the CANMATCH/MATCHMORE modes. Direct matches were getting in the way. Fixed. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112357 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01Fix a typo that prevented configuration of non-dynamic peers.Russell Bryant
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112351 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01Existing DNS manager lookups extended to check for SRV records.Jeff Peeler
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112321 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01(closes issue #12298)Steve Murphy
Reported by: falves11 Patches: 12298.patch1 uploaded by murf (license 17) Tested by: murf I have hopes that the changes made over the last few days will finalize and solidify this code. While there are bound to be small tweaks still needed, I feel that the job (at last) is somewhat completed. Finally, I had a chance to comprehend how the scoring of extension patterns was done in the previous version, and I've come very close to using the exact same criteria in the new pattern matching code. The left-right sorting is now replicated in the trie structure itself, such that the first match found will the 'best' match. Compared the results against 1.4 for several extensions. Replicated falves11's setup and it works. Used some devious patterns provided by jsmith, supplemented with a few of my own. Looks good. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112289 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01Minor formatting cleanup.Jason Parker
(closes issue #12343) Reported by: travishein Patches: app_voicemail_code_convention.patch uploaded by travishein (license 385) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112252 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01More voicemail doxygen additions/cleanup.Jason Parker
(issue #12343) Reported by: travishein Patches: app_voicemail_code_documentation.patch uploaded by travishein (license 385) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112241 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01Fix last commitTilghman Lesher
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112234 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01Merged revisions 112209 via svnmerge from Joshua Colp
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r112209 | file | 2008-04-01 15:02:43 -0300 (Tue, 01 Apr 2008) | 4 lines Disable Packet2Packet bridging when we need to feed DTMF frames into the core. Some implementations do not like how we switch between things. (closes issue #12212) Reported by: bamby ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112210 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01This adds DNS SRV record support to DNS manager. If there is a SRV record ↵Jeff Peeler
for a given domain, the hostname and port listed in the SRV record will be used. If no SRV record exists or a SRV lookup is not attempted, the DNS lookup on the specified domain will be performed as normal. Chan_sip has been modified to take advantage of the new SRV support. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112207 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01Merged revisions 112204 via svnmerge from Joshua Colp
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r112204 | file | 2008-04-01 14:43:46 -0300 (Tue, 01 Apr 2008) | 4 lines Do not pass audio until the remote side has indicated they are providing early media, or if the channel has been answered. (closes issue #11823) Reported by: SDamm ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112205 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01Demote a log message down to a warning.Joshua Colp
(closes issue #12345) Reported by: caio1982 Patches: limit_msg.diff uploaded by caio1982 (license 22) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112155 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01Merged revisions 112138 via svnmerge from Mark Michelson
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r112138 | mmichelson | 2008-04-01 12:21:21 -0500 (Tue, 01 Apr 2008) | 10 lines Initialize the __res_state structure used for dns purposes to all 0's prior to using it. This is due to valgrind's complaints on issue #12284 as well as an excerpt found in "Description" portion of the online man page found here: http://www.iti.cs.tu-bs.de/cgi-bin/UNIXhelp/man-cgi?res_nquery+3RESOLV (pertains to issue #12284 but does not necessarily close it) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112148 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01Merged revisions 112125 via svnmerge from Joshua Colp
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r112125 | file | 2008-04-01 13:45:14 -0300 (Tue, 01 Apr 2008) | 5 lines Ensure that we do not exceed the hold's maximum size with a single frame. (closes issue #12047) Reported by: fabianoheringer Tested by: fabianoheringer ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112126 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01Now that zaptel trunk has been removed, add the PSTN deprecation notice to ↵Russell Bryant
chan_zap, as well. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112124 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-31I missed a place when this define was changed.Jason Parker
(closes issue #12334) Reported by: ovi Patches: 12334-asterisk.patch uploaded by dimas (license 88) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112071 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-31Merged revisions 112068 via svnmerge from Jason Parker
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r112068 | qwell | 2008-03-31 16:48:05 -0500 (Mon, 31 Mar 2008) | 5 lines Fix a silly infinite loop when choosing an invalid option. (closes issue #12315) Reported by: jmls ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112069 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-31Yeah, simplify that logic a bit...Terry Wilson
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112035 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-31Handle blank prefix= in http.confTerry Wilson
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112033 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-31Ensure configure gets run on a clean checkout.Russell Bryant
(closes issue #12197) Reported by: juggie Patches: 12197.diff uploaded by juggie (license 24) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111998 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-31This fixes a high fence violation that MALLOC_DEBUG reported to me.Russell Bryant
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111996 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-31Initialize all these here tmp pointers at declaration. They confused some ↵Joshua Colp
compilers a wee bit. (closes issue #12333) Reported by: ovi git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111961 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28Make some notes about common usage of pbx_builtin_getvar_helper() that is notRussell Bryant
thread-safe. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111909 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28Note a minor race condition that I noticed while reviewing Jeff's changesRussell Bryant
to this code. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111908 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28Merged revisions 111856 via svnmerge from Jason Parker
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r111856 | qwell | 2008-03-28 16:45:35 -0500 (Fri, 28 Mar 2008) | 12 lines Allow gsm to compile correctly on x86 with gcc4 optimizations. (closes issue #11243) Reported by: whiskerp Patches: 11243-maybe-asm.diff uploaded by qwell (license 4) Tested by: Seggy (IRC) Note: While I did write this patch, I would not have found this if fossil had not reported and fixed issue #12253. A huge thanks to him for helping to (indirectly) find the problem here. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111857 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28This time the fix is proper for issue 12284. I have tested it thoroughly and ↵Mark Michelson
found that valgrind no longer complains and that calls do complete correctly. The fix is along the same lines as before: Make sure the final null terminator gets copied into the new sip_request's data pointer. Without it, parse_request will read and potentially write past the end of the string, causing potential crashes. (closes issue #12284...for real this time!) reported by falves11 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111811 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28Temporary revert of 111662. It's causing lots of trouble and appears to not beMark Michelson
the proper solution to the problem reported anyway. (related to issue #12884) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111777 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28Replace magic number size from msgArray array with a define.Jason Parker
(same patch as before, I just split this part out) (close issue #12326) Reported by: travishein Patches: app_voicemail_code_documentation.patch uploaded by travishein (license 385) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111774 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28Add a bit of doxygen documentation for app_voicemail.Jason Parker
(issue #12326) Reported by: travishein Patches: app_voicemail_code_documentation.patch uploaded by travishein (license 385) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111773 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28Merged revisions 111720 via svnmerge from Jason Parker
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r111720 | qwell | 2008-03-28 12:55:05 -0500 (Fri, 28 Mar 2008) | 1 line Remove unimplemented softkeys. Prompted by issue #12325. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111721 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28The copy_request function did not take into account the necessary null ↵Mark Michelson
terminator for the string to be copied into. This resulted in parse_request reading invalid memory beyond the end of the string, and in some cases led to crashes. Thanks to falves11 for providing the valgrind output which led to the closure of this issue. (closes issue #12284) Reported by: falves11 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111662 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28Merged revisions 111658 via svnmerge from Jason Parker
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r111658 | qwell | 2008-03-28 11:19:56 -0500 (Fri, 28 Mar 2008) | 8 lines The file size of WAV49 does not need to be an even number. (closes issue #12128) Reported by: mdu113 Patches: 12128-noevenlength.diff uploaded by qwell (license 4) Tested by: qwell, mdu113 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111659 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28Merged revisions 111605 via svnmerge from Tilghman Lesher
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r111605 | tilghman | 2008-03-28 09:35:45 -0500 (Fri, 28 Mar 2008) | 3 lines Update debugging text, since Valgrind eliminated the --log-file-exactly option. (Closes issue #12320) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111606 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28Forgetting to unregister a manager action is bad, mmmk?Joshua Colp
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111565 65c4cc65-6c06-0410-ace0-fbb531ad65f3
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 03:55:57 +0000