summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-11-09Merge "res_pjsip_session: Fix multiple leaks."Joshua Colp
2017-11-09Merge "main/sdp_state: Check for errors from ast_stream_topology_set_stream."Joshua Colp
2017-11-09Merge "bridge_softmix: Note why ast_stream_topology_set_stream cannot fail."Joshua Colp
2017-11-09Merge "res_pjsip_session: Check for errors from ast_stream_topology_set_stream."Joshua Colp
2017-11-08Merge "res_pjsip_t38: Better error checking for t38_create_media_state."Joshua Colp
2017-11-08bridge_softmix: Note why ast_stream_topology_set_stream cannot fail.Corey Farrell
This appeared in my audit of ast_stream_topology_set_stream callers not checking for errors but in this situation the call cannot fail. Add comment so this can be ignored in the future. Change-Id: I91d25704859efbe50b8b82cfe1cd3c40ba177c9f
2017-11-08Merge "AST-2017-009: pjproject: Add validation of numeric header values"George Joseph
2017-11-08Merge "AST-2017-011 - res_pjsip_session: session leak when a call is rejected"George Joseph
2017-11-08Merge "AST-2017-010: Fix cdr_object_update_party_b_userfield_cb() buf overrun"George Joseph
2017-11-08Merge "res_pjproject.c: Fix ast_strdup() alloc failure."Joshua Colp
2017-11-08AST-2017-011 - res_pjsip_session: session leak when a call is rejectedKevin Harwell
A previous commit made it so when an invite session transitioned into a disconnected state destruction of the Asterisk pjsip session object was postponed until either a transport error occurred or the event timer expired. However, if a call was rejected (for instance a 488) before the session was fully established the event timer may not have been initiated, or it was canceled without triggering either of the session finalizing states mentioned above. Really the only time destruction of the session should be delayed is when a BYE is being transacted. This is because it's possible in some cases for the session to be disconnected, but the BYE is still transacting. This patch makes it so the session object always gets released (no more memory leak) when the pjsip session is in a disconnected state. Except when the method is a BYE. Then it waits until a transport error occurs or an event timeout. ASTERISK-27345 #close Reported by: Corey Farrell Change-Id: I1e724737b758c20ac76d19d3611e3d2876ae10ed
2017-11-08AST-2017-010: Fix cdr_object_update_party_b_userfield_cb() buf overrunRichard Mudgett
cdr_object_update_party_b_userfield_cb() could overrun the fixed buffer if the supplied string is too long. The long string could be supplied by external means using the CDR(userfield) function. This may seem reminiscent to AST-2017-001 (ASTERISK_26897) and it is. The earlier patch fixed the buffer overrun for Party A's userfield while this patch fixes the same thing for Party B's userfield. ASTERISK-27337 Change-Id: I0fa767f65ecec7e676ca465306ff9e0edbf3b652
2017-11-08AST-2017-009: pjproject: Add validation of numeric header valuesGeorge Joseph
Parsing the numeric header fields like cseq, ttl, port, etc. all had the potential to overflow, either causing unintended values to be captured or, if the values were subsequently converted back to strings, a buffer overrun. To address this, new "strto" functions have been created that do range checking and those functions are used wherever possible in the parser. * Created pjlib/include/limits.h and pjlib/include/compat/limits.h to either include the system limits.h or define common numeric limits if there is no system limits.h. * Created strto*_validate functions in sip_parser that take bounds and on failure call the on_str_parse_error function which prints an error message and calls PJ_THROW. * Updated sip_parser to validate the numeric fields. * Fixed an issue in sip_transport that prevented error messages from being properly displayed. * Added "volatile" to some variables referenced in PJ_CATCH blocks as the optimizer was sometimes optimizing them away. * Fixed length calculation in sip_transaction/create_tsx_key_2543 to account for signed ints being 11 characters, not 9. ASTERISK-27319 Reported by: Youngsung Kim at LINE Corporation Change-Id: I48de2e4ccf196990906304e8d7061f4ffdd772ff
2017-11-08Merge "stream: Return error from ast_stream_topology_set_stream."Jenkins2
2017-11-08Merge "res_stasis: Fix multiple leaks."Joshua Colp
2017-11-07res_pjsip_session: Fix multiple leaks.Corey Farrell
* Pre-initialize cloned media state vectors to final size to ensure vector errors cannot happen later in the clone initialization. * Release session_media on vector replace failure in ast_sip_session_media_state_add. * Release clone and media_state in ast_sip_session_refresh if we fail to append to the stream topology, return an error. Change-Id: Ib5ffc9b198683fa7e9bf166d74d30c1334c23acb
2017-11-07Merge "res_pjsip_outbound_registration: Fix leak on vector add failure."Jenkins2
2017-11-07Merge "res_pjsip_exten_state: Check for vector append failure."Jenkins2
2017-11-07Merge "res_pjsip_config_wizard: Fix leaks and add check for malloc failure."Jenkins2
2017-11-07Merge "res_stasis_playback: Check for failure to append vector."Jenkins2
2017-11-07Merge "res_pjsip: Fix leak on error in ast_sip_auth_vector_init."Jenkins2
2017-11-07Merge "test_sorcery_memory_cache_thrash: Handle error from vector append."Jenkins2
2017-11-07Merge "stasis: Release object if vector append fails."Jenkins2
2017-11-07Merge "res_ari_events: Fix use after free / double-free of JSON message."Jenkins2
2017-11-07Merge "PBX: Handle errors from AST_VECTOR_APPEND."Jenkins2
2017-11-07Merge "Messaging: Report error on failure to register tech or handler."Jenkins2
2017-11-07Merge "format_cap: Fix leak on AST_VECTOR_APPEND error."Jenkins2
2017-11-07Merge "CLI: Remove unused internal command."Jenkins2
2017-11-07Merge "res_pjsip: Avoid crash when contact uri is empty string"Jenkins2
2017-11-07main/sdp_state: Check for errors from ast_stream_topology_set_stream.Corey Farrell
Change-Id: I84a83ae69daba5d185cc1d939b133a4c23565497
2017-11-07res_pjsip_session: Check for errors from ast_stream_topology_set_stream.Corey Farrell
Free memory and return error if ast_stream_topology_set_stream fails. Change-Id: I9f4dbf44bed627243d2f1dd8aea2eab6c38a028d
2017-11-07res_pjsip_t38: Better error checking for t38_create_media_state.Corey Farrell
Change-Id: I81b2587427c6982aa3e2a3f9ad69cce8d316eb10
2017-11-07Merge "res_pjsip: Ignore empty TLS configuration"Jenkins2
2017-11-07stream: Return error from ast_stream_topology_set_stream.Corey Farrell
ast_stream_topology_set_stream had suppressed error codes from AST_VECTOR_APPEND. The result of AST_VECTOR_APPEND needs to be returned to the caller so they can take appropriate action on the stream. Change-Id: I6c0d12755743eadba1357f6153526cc055592856
2017-11-07res_stasis: Fix multiple leaks.Corey Farrell
* res/stasis/app.c JSON passed to app_send needs to be released. * res/stasis_message.c: objects leak if vector append fails. Change-Id: I8dd5385b9f50a5cadf2b1d16efecffd6ddb4db4a
2017-11-07Merge "tcptls: Print notice when TLS is enabled but not configured."Joshua Colp
2017-11-07Merge "stasis: Remove silly use of RAII_VAR in stasis_forward_all."Joshua Colp
2017-11-07Merge "stasis_channels.c: Remove a very silly RAII_VAR()."Joshua Colp
2017-11-07Merge "stasis/app.c: Optimize stasis_app_get_debug_by_name()"Joshua Colp
2017-11-07Merge "Fix ast_(v)asprintf() malloc failure usage conditions."Joshua Colp
2017-11-07res_pjproject.c: Fix ast_strdup() alloc failure.Richard Mudgett
Change-Id: I74688038e7afe3a279359cce53aadb28ade51ead
2017-11-07res_pjsip: Avoid crash when contact uri is empty stringAaron An
Asterisk will crash if contact uri is invalid, so contact_apply_handler should check if the uri is NULL or empty. ASTERISK-27393 #close Reported-by: Aaron An Tested-by: AaronAn Change-Id: Ia0309bdc6b697c73c9c736e1caec910b77ca69f5
2017-11-07Merge "RTP Engine: Deal with errors returned from AST_VECTOR_REPLACE."Joshua Colp
2017-11-06res_pjsip_outbound_registration: Fix leak on vector add failure.Corey Farrell
Change-Id: I774b88b3c9da41edd4dc8d78f095481f52f2bd46
2017-11-06res_pjsip_exten_state: Check for vector append failure.Corey Farrell
Release reference to publisher if we fail to add it to the vector. Change-Id: I64dff3f481b67b9884f37cadba7a5ccf23d084f3
2017-11-06res_pjsip_config_wizard: Fix leaks and add check for malloc failure.Corey Farrell
wizard_apply_handler(): - Free host if we fail to add it to the vector. wizard_mapped_observer(): - Check for otw allocation failure. - Free otw if we fail to add it to the vector. Change-Id: Ib5d3bcabbd9c24dd8a3c9cc692a794a5f60243ad
2017-11-06res_stasis_playback: Check for failure to append vector.Corey Farrell
Free resources and return error if we fail to append the vector in stasis_app_control_play_uri. Change-Id: I22c4a90dd859b253f2850c6511de48b25609422b
2017-11-06test_sorcery_memory_cache_thrash: Handle error from vector append.Corey Farrell
Cleanup resources when we fail to append the vector and report test failure. Change-Id: I6eb41586fd11dee8c0dfe35e91cb465a4cab7298
2017-11-06res_pjsip: Fix leak on error in ast_sip_auth_vector_init.Corey Farrell
Change-Id: Ib0fc7a18f3135ca8990c3984c9e15f6d26e556e8
2017-11-06res_pjproject: Handle error from adding to the buildopts vector.Corey Farrell
Change-Id: I076c7bd207c7989a23005395ce1735392657be65
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-11 01:12:48 +0000