summaryrefslogtreecommitdiff
path: root/channels
AgeCommit message (Collapse)Author
2008-10-22The logic of a strncasecmp call was reversed.Mark Michelson
(closes issue #13706) Reported by: andrew53 Patches: sip_notify_from_rfc3265.patch uploaded by andrew53 (license 519) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151512 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-21Make the sip_standard_port function more granular by allowing separateMark Michelson
type and port arguments. This is necessary because when building our From and Contact headers, we need to be absolutely sure that we are placing our source port there and not the peer's source port. (closes issue #12761) Reported by: asbestoshead Patches: patch-chan-sip-contact-port.txt uploaded by asbestoshead (license 455) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151464 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-21Get this compiling in dev-modeMark Michelson
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151439 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-21If a peer uses any transport other than UDP, then MWI willMark Michelson
fail for that peer since sip_alloc will allocate a sip_pvt with a default transport of UDP. This change resets the socket type immediately after allocating the sip_pvt in sip_send_mwi_from_peer, so that the proceeding call to create_addr_from_peer does not fail right away. The socket data from the peer is properly copied to the sip_pvt in create_addr_from_peer. (closes issue #13710) Reported by: andrew53 Patches: sip_notify_use_tcp.patch uploaded by andrew53 (license 519) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151428 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-21When attempting to resolve hostnames, we need to be sureMark Michelson
to remove any parameters from the string so that name resolution succeeds. (closes issue #13727) Reported by: fnordian Patches: resolvewithouturiparameter.patch uploaded by fnordian (license 110) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151420 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-21 Fix configuration parsing so type=friend still identifies "friend" as a ↵BJ Weschke
peer even though it is now a legacy configuration verb. (closes issue #13705) reported by: blitzrage patched by: bweschke git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151327 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-19cleaup of the TCP/TLS socket API:Kevin P. Fleming
1) rename 'struct server_args' to 'struct ast_tcptls_session_args', to follow coding guidelines 2) make ast_make_file_from_fd() static and rename it to something that indicates what it really is for (again coding guidelines) 3) rename address variables inside 'struct ast_tcptls_session_args' to be more descriptive (dare i say it... coding guidelines) 4) change ast_tcptls_client_start() to use the new 'remote_address' field of the session args for the destination of the connection, and use the 'local_address' field to bind() the socket to the proper source address, if one is supplied 5) in chan_sip, ensure that we pass in the PP address we are bound to when creating outbound (client) connections, so that our connections will appear from the correct address git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151101 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-19dont segfault when placing a call to a line that has no registered device.Michiel van Baak
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151060 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-19Adding changes from train and flight back home from SIPit23 in Lannion, France.Olle Johansson
- Additional comments on TCP/TLS implementation - Some additions for new drafts/rfcs (no new functionality really, mostly documentation) - Other random small fixes git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151019 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17Merge in patch for #13454. Includes CallRereouting dialplan application, ↵Matthew Fredrickson
option for discard of remote hold messages, and using the alternate logical channel mapping in Q.SIG instead of the default physical channel mapping. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150640 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17Make helper call a little safer (suggested by Russell on IRC)Tilghman Lesher
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150635 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17Fix the FRACK! warnings in chan_iax2 when POKE/LAGRQ packets are not answered.Tilghman Lesher
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150580 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17Adding some additional thoughts on configuration changes to TCP/TLSOlle Johansson
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150510 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17Break up skinny.conf into seperate sections forMichiel van Baak
devices and lines. (closes issue #13412) Reported by: wedhorn Patches: config-restruct-v4.diff uploaded by wedhorn (license 30) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150426 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17Add an IAXregistry manager command. See doc/manager_1_1.txtMark Michelson
for more details of this command. (closes issue #13326) Reported by: ib2 Patches: bug13326_trunk_20080822.diff uploaded by snuffy (license 35) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150311 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17After a long discussion on #asterisk-bugs, it seems kind ofMark Michelson
odd that a channel would be named after the originating port. For endpoints that always include ":5060" as part of the From: header, it will mean that you have a ton of channels with names like "SIP/5060-3ea38a8b." I am boldly moving forward with this change in trunk, but I'm not touching other branches with this one since this definitely would qualify as a behavior change. If there is a problem with this commit, and I haven't seen the obvious reason why you'd want to name the channel after the port from which the call originated, then please feel free to revert this git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150307 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16Remove an odd redundant comparisonMark Michelson
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150253 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16INVITES with proxy auth were sent with a different branchMark Michelson
than what was in the invite_branch of a sip_pvt, meaning that if a CANCEL were sent later, the branch in the CANCEL would not match the branch in the latest INVITE sent out, leading to some endpoints responding to the CANCEL with a 481. (closes issue #13714) Reported by: fnordian Patches: invite_branch.patch uploaded by fnordian (license 110) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150207 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16Merged revisions 150124 via svnmerge from Richard Mudgett
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r150124 | rmudgett | 2008-10-16 10:56:06 -0500 (Thu, 16 Oct 2008) | 1 line Fix memory leak found by customer ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150125 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16ensure that type=peer entries are only matched on IP/port, not on name ↵Kevin P. Fleming
(after oej audits all the calls to find_peer() to make sure that forcenamematch is set correctly in each case) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150052 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16Doxygen additionOlle Johansson
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150051 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16Add some notes on problems with the TCP/TLS implementationOlle Johansson
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150008 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16return this logic to where it used to be, *after* the dialog->needdestroy ↵Kevin P. Fleming
flag has been determined to be set; otherwise, we generate these debug messages every time we inspect every active dialog git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149981 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16some additional debugging tools added at SIPit23:Kevin P. Fleming
- move all setting of 'needdestroy' on dialog structures into the history - report all tags involved when a pedantic check fails on a REFER git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149964 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-15Make the sip_proxy struct reference counted. This isMark Michelson
necessary to allow for a sip_pvt to maintain a reference to a sip_peer's outboundproxy even after the peer has been freed. (closes issue #13700) Reported by: fnordian Patches: 13700.patch uploaded by putnopvut (license 60) Tested by: fnordian git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149802 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-15Adding a note about a missing part of "kill-the-user" - I got lost in the ↵Olle Johansson
Ao2 world... We're going to try to get time to fix this and kpfleming believes that there's code in ao2 so that we can solve it... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149542 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-15Merged revisions 149452 via svnmerge from Kevin P. Fleming
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r149452 | kpfleming | 2008-10-15 12:30:40 +0200 (Wed, 15 Oct 2008) | 3 lines fix some problems when parsing SIP messages that have the maximum number of headers or body lines that we support ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149487 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-15Fixing sytax errors ;-)Olle Johansson
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149342 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14Merged revisions 149266 via svnmerge from Mark Michelson
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r149266 | mmichelson | 2008-10-14 18:43:58 -0500 (Tue, 14 Oct 2008) | 4 lines Change this warning to an error message. Suggestion comes from Sean Bright. Thanks Sean! ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149271 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14Merged revisions 149207 via svnmerge from Mark Michelson
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r149207 | mmichelson | 2008-10-14 18:10:26 -0500 (Tue, 14 Oct 2008) | 9 lines Call register_peer_exten even in the case that the peer's IP/port does not change. (closes issue #13309) Reported by: dimas Patches: v2-13309.patch uploaded by dimas (license 88) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149208 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14Add additional memory debugging to several core APIs, and fix several memoryTilghman Lesher
leaks found with these changes. (Closes issue #13505, closes issue #13543) Reported by: mav3rick, triccyx Patches: 20081001__bug13505.diff.txt uploaded by Corydon76 (license 14) Tested by: mav3rick, triccyx git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149199 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14Merged revisions 149130 via svnmerge from Mark Michelson
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r149130 | mmichelson | 2008-10-14 15:49:02 -0500 (Tue, 14 Oct 2008) | 7 lines Don't allow reserved characters to be used in register lines in sip.conf. (closes issue #13570) Reported by: putnopvut ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149131 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14Merged revisions 148912 via svnmerge from Mark Michelson
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r148912 | mmichelson | 2008-10-14 12:33:38 -0500 (Tue, 14 Oct 2008) | 9 lines Deadlock prevention in chan_local. (closes issue #13676) Reported by: tacvbo Patches: 13676.patch uploaded by putnopvut (license 60) Tested by: tacvbo ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148913 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14Fix reference count issue that Russell brought up in SIP MWI NOTIFY support. ↵Joshua Colp
Bump the reference count up before we add it to the scheduler, duh. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148867 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14fix some references to the owner of a private structure that may not be presentKevin P. Fleming
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148754 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14this structure should be staticKevin P. Fleming
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148737 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14ensure that *all* fields in the req structure are cleared out before reusing ↵Kevin P. Fleming
it; has_to_tag was not cleared, which caused the second incoming call over a TCP socket to fail if pedantic checking was enabled git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148695 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14Adding some clarificationsOlle Johansson
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148679 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-13- Doxygen formatting. (tss tss)Olle Johansson
- Fixing language git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148474 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-13Highlightning even more bugs in the current tcp/tls implementation.Olle Johansson
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148473 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-13Sending a 403 after a 200 is considered very bad.Olle Johansson
(found at SIPit) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148471 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-10The logic used when checking a peer got changed subtlyMark Michelson
in the "kill the user" commit and caused calls relying on the insecure setting to not work properly. I changed for finding a peer back to how it was prior to that commit. (closes issue #13644) Reported by: pj Patches: 13644_trunkv2.patch uploaded by putnopvut (license 60) Tested by: pj git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148376 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-10Make sure that the inUse and inRinging fields for Mark Michelson
a sip peer cannot go below zero. This is a regression from 1.4 and so it will be applied to 1.6.0 as well. (closes issue #13668) Reported by: mjc git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148373 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09Reverting format addition for nowTilghman Lesher
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148071 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09Fudges for wav16, just like wav49Tilghman Lesher
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148070 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09fix some CLI commands we borked during devcon2008Michiel van Baak
Thanks rmudget for letting me know and providing hints on how to fix it best. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147853 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09(closes issue #13557)Steve Murphy
Reported by: nickpeirson Patches: pbx.c.patch uploaded by nickpeirson (license 579) replace_bzero+bcopy.patch uploaded by nickpeirson (license 579) Tested by: nickpeirson, murf 1. replaced all refs to bzero and bcopy to memset and memmove instead. 2. added a note to the CODING-GUIDELINES 3. add two macros to asterisk.h to prevent bzero, bcopy from creeping back into the source 4. removed bzero from configure, configure.ac, autoconfig.h.in git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147807 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09Add support for subscribing to a voice mailbox on a remote SIP server and ↵Joshua Colp
making the new/old message count available to local devices. (issue #AST-77) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147760 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-08Merged revisions 147681 via svnmerge from Kevin P. Fleming
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r147681 | kpfleming | 2008-10-08 17:22:09 -0500 (Wed, 08 Oct 2008) | 3 lines when parsing a text configuration option, ensure that the buffer on the stack is actually large enough to hold the legal values of that option, and also ensure that sscanf() knows to stop parsing if it would overrun the buffer (without these changes, specifying "buffers=...,immediate" would overflow the buffer on the stack, and could not have worked as expected) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147689 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-07Move the DAHDI-to-DAHDI operator mode check from app_dial into chan_dahdiSean Bright
so we don't have to hardcode anything. (closes issue #13636) Reported by: seanbright Patches: 13636.diff uploaded by seanbright (license 71) Reviewed by: russellb, putnopvut git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147388 65c4cc65-6c06-0410-ace0-fbb531ad65f3