summaryrefslogtreecommitdiff
path: root/channels
AgeCommit message (Collapse)Author
2008-12-02Merged revisions 160207 via svnmerge from Tilghman Lesher
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r160207 | tilghman | 2008-12-01 18:25:16 -0600 (Mon, 01 Dec 2008) | 3 lines Ensure that Asterisk builds with --enable-dev-mode, even on the latest gcc and glibc. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160208 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-01Silence a build warning. (chan_phone.c:810: warning: value computed is not used)Sean Bright
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160171 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-01Merged revisions 160003 via svnmerge from Russell Bryant
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r160003 | russell | 2008-12-01 11:27:30 -0600 (Mon, 01 Dec 2008) | 6 lines Apply some logic used in iax2_indicate() to iax2_setoption(), as well, since they both have the potential to send control frames in the middle of call setup. We have to wait until we have received a message back from the remote end before we try to send any more frames. Otherwise, the remote end will consider it invalid, and we'll get stuck in an INVAL/VNAK storm. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160004 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-29incorporates r159808 from branches/1.4:Kevin P. Fleming
------------------------------------------------------------------------ r159808 | kpfleming | 2008-11-29 10:58:29 -0600 (Sat, 29 Nov 2008) | 7 lines update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors since this branch already had some printf format attributes, enable checking for them and tag functions that didn't have them format attributes in a consistent way ------------------------------------------------------------------------ in addition: move some format attributes from main/utils.c to the header files they belong in, and fix up references to the relevant functions based on new compiler warnings git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159818 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-29we can now build with -Wformat=2, which found a couple of real bugsKevin P. Fleming
because SPRINTF() use non-literal format strings (which cannot be checked), move it into its own module so the rest of func_strings can benefit from format string checking git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159774 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-26Don't allow for configuration options to overwrite optionsMark Michelson
set via channel variables on a reload. (closes issue #13921) Reported by: davidw Patches: 13921.patch uploaded by putnopvut (license 60) Tested by: davidw git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159437 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-25Merged revisions 159316 via svnmerge from Steve Murphy
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r159316 | murf | 2008-11-25 15:41:10 -0700 (Tue, 25 Nov 2008) | 15 lines (closes issue #12694) Reported by: yraber Patches: 12694.2nd.diff uploaded by murf (license 17) Tested by: murf, laurav Thanks to file (Joshua Colp) for his IAX fix. the change to cdr.c allows no-answer to percolate up into CDR's, and feels like the right place to locate this fix; if BUSY is done here, no-answer should be, too. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159360 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-25Add an option, waitfordialtone, for UK analog lines which do not end a callTilghman Lesher
until the originating line hangs up. (closes issue #12382) Reported by: one47 Patches: zap-waitfordialtone-trunk.080901.patch uploaded by one47 (license 23) zap-waitfordialtone-bra-1.4.21.2.patch uploaded by fleed (license 463) Tested by: fleed git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159317 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-25Merged revisions 159269 via svnmerge from Tilghman Lesher
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r159269 | tilghman | 2008-11-25 15:56:48 -0600 (Tue, 25 Nov 2008) | 7 lines Don't try to send a response on a NULL pvt. (closes issue #13919) Reported by: barthpbx Patches: chan_iax2.c.patch uploaded by eliel (license 64) Tested by: barthpbx ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159276 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-25Merged revisions 159246 via svnmerge from Tilghman Lesher
https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r159246 | tilghman | 2008-11-25 15:40:28 -0600 (Tue, 25 Nov 2008) | 14 lines Merged revisions 159245 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r159245 | tilghman | 2008-11-25 15:37:06 -0600 (Tue, 25 Nov 2008) | 7 lines Regression fix for last security fix. Set the iseqno correctly. (closes issue #13918) Reported by: ffloimair Patches: 20081119__bug13918.diff.txt uploaded by Corydon76 (license 14) Tested by: ffloimair ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159247 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-25Merged revisions 159025 via svnmerge from Tilghman Lesher
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r159025 | tilghman | 2008-11-24 22:50:00 -0600 (Mon, 24 Nov 2008) | 3 lines System call ioperm is non-portable, so check for its existence in autoconf. (Closes issue #13863) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159050 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-25Make chan_usbradio compile under dev modeTerry Wilson
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158992 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-25This is basically a complete rollback of r155401, as it was determined thatSean Bright
it would be best to maintain API compatibility. Instead, this commit introduces ao2_callback_data() which is functionally identical to ao2_callback() except that it allows you to pass arbitrary data to the callback. Reviewed by Mark Michelson via ReviewBoard: http://reviewboard.digium.com/r/64 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158959 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-23If you enabled 'notifycid' one of the limitations is that the calling channelSean Bright
is only found if it dialed the extension that was subscribed to. You can now specify 'ignore-context' for the 'notifycid' option in sip.conf which will, as it's value implies, ignore the current context of the caller when doing the lookup. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158756 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-23No need to use a separate structure for this since we can just passSean Bright
our sip_pvt pointer in directly. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158754 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-22dont send reorder tone after a device is hungup if a dialout is abandoned or ↵Michiel van Baak
failed. Without this reorder tone will play after hangup and both wedhorn's and my wife have threatened to use an axe on our asterisk box (closes issue #13948) Reported by: wedhorn Patches: switch.diff uploaded by wedhorn (license 30) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158694 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-22Add Media Source Update to skinny's control2strMichiel van Baak
(issue #13948) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158690 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-22fix a very occasional core dump in chan_skinny found by wedhorn.Michiel van Baak
(issue #13948) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158688 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-21Fix for #13963. Make physical channel mapping unconfigured defaultMatthew Fredrickson
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158482 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-21Add fix to prevent crash during reload if there is an outstanding MWI ↵Doug Bailey
registration message pending. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158315 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-21Use a more expressive constant for a 64-bit scanned intMark Michelson
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158266 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-21Use some magic constants to get the right sizeMark Michelson
for this sscanf statement. Thanks Richard! git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158265 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-21Fix the build for 32-bit systems. %lu is only 32-bitsMark Michelson
on 32-bit systems, so we need to use %llu instead. Of course %llu is 128-bits on 64-bit systems, so we have to cast to unsigned long long. No harm, but it's sure annoying. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158262 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-20Change the remote user agent session version variableMark Michelson
from an int to a uint64_t. This prevents potential comparison problems from happening if the version string exceeds INT_MAX. This was an apparent problem for one user who could not properly place a call on hold since the version in the SDP of the re-INVITE to place the call on hold greatly exceeded INT_MAX. This also aligns with RFC 2327 better since it recommends using an NTP timestamp for the version (which is a 64-bit number). (closes issue #13531) Reported by: sgofferj Patches: 13531.patch uploaded by putnopvut (license 60) Tested by: sgofferj git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158230 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-20Merged revisions 158072 via svnmerge from Mark Michelson
https://origsvn.digium.com/svn/asterisk/trunk ........ r158072 | twilson | 2008-11-20 11:48:58 -0600 (Thu, 20 Nov 2008) | 2 lines Begin on a crusade to end trailing whitespace! ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158133 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-20Merged revisions 158071 via svnmerge from Mark Michelson
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r158071 | mmichelson | 2008-11-20 11:48:42 -0600 (Thu, 20 Nov 2008) | 16 lines We don't handle 4XX responses to BYE well. According to section 15 of RFC 3261, we should terminate a dialog if we receive a 481 or 408 in response to our BYE. Since I am aware of at least one phone manufacturer who may sometimes send a 404 as well, I am being liberal and saying that any 4XX response to a BYE should result in a terminated dialog. (closes issue #12994) Reported by: pabelanger Patches: 12994.patch uploaded by putnopvut (license 60) Closes AST-129 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158082 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-20Merged revisions 158053 via svnmerge from Mark Michelson
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r158053 | mmichelson | 2008-11-20 11:33:06 -0600 (Thu, 20 Nov 2008) | 12 lines Make sure to set the hangup cause on the calling channel in the case that ast_call() fails. For incoming SIP channels, this was causing us to send a 603 instead of a 486 when the call-limit was reached on the destination channel. (closes issue #13867) Reported by: still_nsk Patches: 13867.diff uploaded by putnopvut (license 60) Tested by: blitzrage ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158066 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-20Merged revisions 157859 via svnmerge from Kevin P. Fleming
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r157859 | kpfleming | 2008-11-19 15:34:47 -0600 (Wed, 19 Nov 2008) | 7 lines the gcc optimizer frequently finds broken code (use of uninitalized variables, unreachable code, etc.), which is good. however, developers usually compile with the optimizer turned off, because if they need to debug the resulting code, optimized code makes that process very difficult. this means that we get code changes committed that weren't adequately checked over for these sorts of problems. with this build system change, if (and only if) --enable-dev-mode was used and DONT_OPTIMIZE is turned on, when a source file is compiled it will actually be preprocessed (into a .i or .ii file), then compiled once with optimization (with the result sent to /dev/null) and again without optimization (but only if the first compile succeeded, of course). while making these changes, i did some cleanup work in Makefile.rules to move commonly-used combinations of flag variables into their own variables, to make the file easier to read and maintain ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157974 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-19Fix checking for CONFIG_STATUS_FILEINVALID so that modules don't crash upon ↵Terry Wilson
trying to parse an invalid config git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157818 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-18Merged revisions 157503 via svnmerge from Mark Michelson
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r157503 | mmichelson | 2008-11-18 16:47:57 -0600 (Tue, 18 Nov 2008) | 13 lines Add some missing invite state changes necessary in the sip_write function. Not setting the invite state correctly on the call was resulting in the Record application leaving empty files. I also have updated the doxygen comment next to the declaration of the INV_EARLY_MEDIA constant to reflect that we also use this state when we *send* a 18X response to an INVITE. (closes issue #13878) Reported by: nahuelgreco Patches: sip-early-media-recording-1.4.22.patch uploaded by nahuelgreco (license 162) Tested by: putnopvut ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157512 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-18Based on Russell's advice on the asterisk-dev list, I haveMark Michelson
changed from using a global lock in update_call_counter to using the locks within the sip_pvt and sip_peer structures instead. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157496 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-18* Add a lock to be used in the update_call_counter function.Mark Michelson
* Revert logic to mirror 1.4's in the sense that it will not allow the call counter to dip below 0. These two measures prevent potential races that could cause a SIP peer to appear to be busy forever. (closes issue #13668) Reported by: mjc Patches: hintfix_trunk_rev152649.patch uploaded by wolfelectronic (license 586) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157427 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-18Merged revisions 157305 via svnmerge from Mark Michelson
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r157305 | mmichelson | 2008-11-18 12:25:55 -0600 (Tue, 18 Nov 2008) | 12 lines Fix a crash in the end_bridge_callback of app_dial and app_followme which would occur at the end of an attended transfer. The error occurred because we initially stored a pointer to an ast_channel which then was hung up due to a masquerade. This commit adds a "fixup" callback to the bridge_config structure to allow for end_bridge_callback_data to be changed in the case that a new channel pointer is needed for the end_bridge_callback. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157306 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-15Fix a few more places where the case insensitive hash should be used sinceRussell Bryant
the comparison is case insensitive. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157041 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-15Use the new case insensitive hash function for console interfaces. The ↵Russell Bryant
comparison function is case insensitive. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157039 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-14Revision 155513 of chan_sip.c in trunk inadvertently Mark Michelson
removed a very important line to set the "len" field for incoming SIP requests. The result was that all incoming SIP messages appeared to be 0-length, meaning Asterisk could do no meaningful processing of anything SIP-related git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@156962 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-14Remove some useless locking and make sure we hangup channels on a link when ↵Matthew Fredrickson
we get a GRS. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@156874 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-13Command offsets were not changed correctly when the command syntax forTilghman Lesher
'pri set debug' was changed from 'pri debug'. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@156647 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-12Merged revisions 156229 via svnmerge from Tilghman Lesher
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r156229 | tilghman | 2008-11-12 12:39:21 -0600 (Wed, 12 Nov 2008) | 11 lines Revert revision 132506, since it occasionally caused IAX2 HANGUP packets not to be sent, and instead, schedule a task to destroy the iax2 pvt structure 10 seconds later. This allows the IAX2 HANGUP packet to be queued, transmitted, and ACKed before the pvt is destroyed. (closes issue #13645) Reported by: dzajro Patches: 20081111__bug13645__3.diff.txt uploaded by Corydon76 (license 14) Tested by: vazir Reviewed: http://reviewboard.digium.com/r/51/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@156243 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-12This commit does two things:Michiel van Baak
- Add CLI aliases module to asterisk. - Remove all deprecated CLI commands from the code Initial work done by file. Junk-Y and lmadsen did a lot of work and testing to get the list of deprecated commands into the configuration file. Deprecated CLI commands are now handled by this new module, see cli_aliases.conf for more info about that. ok russellb@ via reviewboard (closes issue #13735) Reported by: mvanbaak git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@156120 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-11Remove commentary from the issues list for SIP TCP/TLSRussell Bryant
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155929 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-10Merged revisions 155861 via svnmerge from Mark Michelson
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r155861 | mmichelson | 2008-11-10 15:07:39 -0600 (Mon, 10 Nov 2008) | 14 lines Channel drivers assume that when their indicate callback is invoked, that the channel on which the callback was called is locked. This patch corrects an instance in chan_agent where a channel's indicate callback is called directly without first locking the channel. This was leading to some observed locking issues in chan_local, but considering that all channel drivers operate under the same expectations, the generic fix in chan_agent is the right way to go. AST-126 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155863 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-09In order to move away from nested function use, some changes to the recently ↵Sean Bright
introduced ast_channel_search_locked need to be made. Specifically, the caller needs to be able to pass arbitrary data which in turn is passed to the callback. This patch addresses all of the nested functions currently in asterisk trunk. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155590 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-08 - Check for failure when putting the packet in the ast_strRussell Bryant
- fix a spelling error in a header file git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155516 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-08Remove some code that is basically a no-op. Code above this already ensures ↵Russell Bryant
that the buffer is terminated. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155513 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-07Set the invite state to INV_CANCELLED in a place thatMark Michelson
makes more sense. Where it was set before, it was impossible to actually delay sending a CANCEL if we had not yet received a provisional response to an INVITE. (closes issue #13626) Reported by: atis Patches: 13626.patch uploaded by putnopvut (license 60) Tested by: atis git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155467 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-07Add ability to pass arbitrary data to the ao2_callback_fn (called fromSean Bright
ao2_callback and ao2_find). Currently, passing OBJ_POINTER to either of these mandates that the passed 'arg' is a hashable object, making searching for an ao2 object based on outside criteria difficult. Reviewed by Russell and Mark M. via ReviewBoard: http://reviewboard.digium.com/r/36/ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155401 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-07Merged revisions 155398 via svnmerge from Tilghman Lesher
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r155398 | tilghman | 2008-11-07 16:27:32 -0600 (Fri, 07 Nov 2008) | 7 lines Clarify error message. (closes issue #13809) Reported by: denke Patches: 20081104__bug13809.diff.txt uploaded by Corydon76 (license 14) Tested by: denke ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155399 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-07Send call release with unallocated cause instead of normal call clearing, whenTilghman Lesher
invalid extension is called. (closes issue #13408) Reported by: adomjan Patches: chan_dahdi.c-ss7-unallocated-2 uploaded by adomjan (license 487) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155324 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-07stringfields conversion for struct sip_peer, as requested :-)Kevin P. Fleming
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155282 65c4cc65-6c06-0410-ace0-fbb531ad65f3