summaryrefslogtreecommitdiff
path: root/res
AgeCommit message (Collapse)Author
2018-02-05Merge "res_sorcery_realtime.c: Fix ref leak if object failed to apply."Jenkins2
2018-02-03Merge "res_pjsip.c: Fix documentation typos."Jenkins2
2018-02-02endpoint identifiers: Some code cleanup.Richard Mudgett
res_pjsip_endpoint_identifier_user.c: * Fix copy/paste error in find_endpoint(). We were using a constant "anonymous" string instead of the passed in endpoint_name when checking the transport domain for an endpoint match. * Eliminate RAII_VAR in find_endpoint(). * Remove always true check in find_transport_state_in_use(). * Remove useless CMD_STOP in find_transport_state_in_use(). res_pjsip_endpoint_identifier_anonymous.c: * Eliminate RAII_VAR in anonymous_identify(). * Remove always true check in find_transport_state_in_use(). * Remove useless CMD_STOP in find_transport_state_in_use(). Change-Id: I86924c31db5bd225ca0c1219c761b668c6f91189
2018-02-02res_pjsip/config_domain_aliases.c: Add check for missing domain.Richard Mudgett
What is the point of defining an alias and not saying what is being aliased? Change-Id: I98a892016ed61dcf5efeb6619fd748925103f0be
2018-02-02res_pjsip.c: Fix documentation typos.Richard Mudgett
Change-Id: I82ae0b92bfa2ece84a5c684efd9eefdc83ebd068
2018-02-02res_sorcery_realtime.c: Fix ref leak if object failed to apply.Richard Mudgett
Change-Id: I3c7106ff77009754725cee790eadf5da44154ab6
2018-02-01res_pjsip_mwi.c: Fix null pointer crashJoshua Elson
ASTERISK-27652 #close Change-Id: I78a0d38bfd8d0d82830f3d53da04872d6b67284d
2018-02-01Merge "res_pjsip_pubsub: Prune subs with reliable transports at startup"George Joseph
2018-02-01Merge "res_pjsip_registrar_expire: Delete empty module."Jenkins2
2018-01-31Merge "res_pjsip_session: Prevent crash during shutdown."Jenkins2
2018-01-31res_pjsip_registrar_expire: Delete empty module.Corey Farrell
Verified nothing in the testsuite lists this module as a dependency. Change-Id: I90c7d52c7e15e85fde3389d5eaccb05b97848813
2018-01-31res_pjsip_registrar.c: Fix compiler error.Richard Mudgett
Need to include signal.h to define pthread_kill() and SIGURG. Change-Id: I10ae3aa4bf8e7386ac29ade78c0f2caed8e674fa
2018-01-30res_pjsip_session: Prevent crash during shutdown.Corey Farrell
pjproject does not have a function to reverse pjsip_inv_usage_init. This means we need to ignore any calls to the functions once shutdown is final. ASTERISK-27571 #close Change-Id: Ia550fcba563e2328f03162d79fb185f16b7c9b9d
2018-01-30res_pjsip_pubsub: Prune subs with reliable transports at startupGeorge Joseph
In an earlier release, inbound registrations on a reliable transport were pruned on Asterisk restart since the TCP connection would have been torn down and become unusable when Asterisk stopped. This same process is now also applied to inbound subscriptions. Also fixed issues in res_pjsip_registrar where it wasn't handling the monitoring correctly when multiple registrations came in over the same transport. To accomplish this, the pjsip_transport_event feature needed to be refactored to allow multiple monitors (multiple subcriptions or registrations from the same endpoint) to exist on the same transport. Since this changed the API, any external modules that may have used the transport monitor feature (highly unlikey) will need to be changed. ASTERISK-27612 Reported by: Ross Beer Change-Id: Iee87cf4eb9b7b2b93d5739a72af52d6ca8fbbe36
2018-01-29res_pjsip_registrar_expire: Refactor into res_pjsip_registerGeorge Joseph
res_pjsip_registrar_expire remains as an empty module for now. Change-Id: Ib93698938bae548d2199cb542f3692d1a171239f
2018-01-29Merge "Remove redundant module checks and references."Jenkins2
2018-01-26Merge "Add missing OPTIONAL_API and ARI dependences."Jenkins2
2018-01-24Remove redundant module checks and references.Corey Farrell
This removes references that are no longer needed due to automatic references created by module dependencies. In addition this removes most calls to ast_module_check as they were checking modules which are listed as dependencies. Change-Id: I332a6e8383d4c72c8e89d988a184ab8320c4872e
2018-01-24Merge "res_pjsip: Add AMI action 'PJSIPShowContacts'"Jenkins2
2018-01-23res_pjsip: Add AMI action 'PJSIPShowContacts'Sungtae Kim
Add an AMI action which provides information on all configured Contacts. ASTERISK-27581 Change-Id: I2eed42c74bbc725fad26b8b33b1a5b3161950c73
2018-01-22Add missing OPTIONAL_API and ARI dependences.Corey Farrell
I've audited all modules that include any header which includes asterisk/optional_api.h. All modules which use OPTIONAL_API now declare those dependencies in AST_MODULE_INFO using requires or optional_modules as appropriate. In addition ARI dependency declarations have been reworked. Instead of declaring additional required modules in res/ari/resource_*.c we now add them to an optional array "requiresModules" in api-docs for each module. This allows the AST_MODULE_INFO dependencies to include those missing modules. Change-Id: Ia0c70571f5566784f63605e78e1ceccb4f79c606
2018-01-18res_pjsip: Document tlsv1_1 and tlsv1_2 methodsSean Bright
Change-Id: I67ed9039bf3f132fb20ee7a750e0aef0f704d7d3
2018-01-16res_pjsip: Split type=identify to IP address and SIP header matching prioritiesRichard Mudgett
The type=identify endpoint identification method can match by IP address and by SIP header. However, the SIP header matching has limited usefulness because you cannot specify the SIP header matching priority relative to the IP address matching. All the matching happens at the same priority and the order of evaluating the identify sections is indeterminate. e.g., If you had two type=identify sections where one matches by IP address for endpoint alice and the other matches by SIP header for endpoint bob then you couldn't predict which endpoint is matched when a request comes in that matches both. * Extract the SIP header matching criteria into its own "header" endpoint identification method so the user can specify the relative priority of the SIP header and the IP address matching criteria in the global endpoint_identifier_order option. The "ip" endpoint identification method now only matches by IP address. ASTERISK-27491 Change-Id: I9df142a575b7e1e3471b7cda5d3ea156cef08095
2018-01-16Merge "res_stasis_recording: Allow symbolic links in configured recordings dir."Jenkins2
2018-01-15loader: Add dependency fields to module structures.Corey Farrell
* Declare 'requires' and 'enhances' text fields on module info structure. * Rename 'nonoptreq' to 'optional_modules'. * Update doxygen comments. Still need to investigate dependencies among modules I cannot compile. Change-Id: I3ad9547a0a6442409ff4e352a6d897bef2cc04bf
2018-01-15Merge "config_transport: Enable TCP_NODELAY on TLS transports"Jenkins2
2018-01-13config_transport: Enable TCP_NODELAY on TLS transportsGeorge Joseph
We did this for TCP transports already but I'm not sure why we didn't do it for TLS transports. ASTERISK_27474 #not_final_fix Change-Id: I5b1ef4b882f7b859e718236686b7898751dbb262
2018-01-12res_stasis_recording: Allow symbolic links in configured recordings dir.Corey Farrell
If any component of ast_config_AST_RECORDING_DIR is a symbolic link we would incorrectly assume the ARI user was trying to escape the recording path. Create additional check to check the recording directory's realpath, only deny access if both do not match. This is needed by the testsuite when run by 'run-local'. Change-Id: I9145e841865edadcb5f75cead3471ad06bbb56c0
2018-01-12res_config_pgsql: Avoid typecasting an int to unsigned char.Alexander Traud
clang 5.0 warned about this. ASTERISK-27576 Change-Id: If41f400a51973c06cdb9b75462e535b616bfe385
2018-01-11Merge "res_pjsip_endpoint_identifier_ip.c: Remove unnecessary requirement."Jenkins2
2018-01-11Merge "res_pjsip.c: Update the endpoint identification documentation."Jenkins2
2018-01-11Merge "res_pjsip.c: Fix ident_to_str() and refactor ident_handler()."Joshua Colp
2018-01-10Merge "res_pjsip_endpoint_identifier_ip.c: Allow multiple IdentifyDetail AMI ↵Joshua Colp
events."
2018-01-10Merge "res_pjsip: Add AMI action 'PJSIPShowAuths'"Joshua Colp
2018-01-10Merge "res_stasis: Reduce RAII_VAR usage."Joshua Colp
2018-01-09Merge "res_pjsip_session: Always bundle streams if WebRTC is enabled."Jenkins2
2018-01-09res_pjsip.c: Update the endpoint identification documentation.Richard Mudgett
* Endpoint identify_by documentation. * IP/Header endpoint identifier documentation. Change-Id: Id92f00b495acca7be945daf749d2abd7f76a0b5a
2018-01-09res_pjsip_endpoint_identifier_ip.c: Remove unnecessary requirement.Richard Mudgett
The requirement that "ip" must be in the endpoint identify_by list to allow the type=identify method to identify the endpoint is not necessary. The "ip" identifier method can match one and only one endpoint. To even work, the "ip" identifier method configuration must explicitly specify the identified endpoint. Therefore, why bother configuring the type=identify identifier in the first place? The requirement only adds the potential for configuration errors for no benefit. Even worse, those configuration errors cannot be detected when the configuration loads. The requirement was introduced with the ASTERISK_27206 patch. * Remove the code change that enforces the requiremnt. Listing the "ip" method in the identify_by value is simply documentation. Change-Id: Ia057f92a33fb5d9f51dc5d5692e3d5ee1a6f2c11
2018-01-09res_pjsip.c: Fix ident_to_str() and refactor ident_handler().Richard Mudgett
* Extracted sip_endpoint_identifier_type2str() and sip_endpoint_identifier_str2type() to simplify the calling functions. * Fixed pjsip_configuration.c:ident_to_str() building the endpoint's identify_by value string. Change-Id: Ide876768a8d5d828b12052e2a75008b0563fc509
2018-01-09res_pjsip_endpoint_identifier_ip.c: Allow multiple IdentifyDetail AMI events.Richard Mudgett
The AMI PJSIPShowEndpoint action could only list one IdentifyDetail AMI event per endpoint. However, there is no reason that multiple type=identify sections cannot identify the same endpoint. * Reworked format_ami_endpoint_identify() to generate as many IdentifyDetail AMI events as there are matching identifiers. Change-Id: Ie146792aef72d78e05416ab5b27bc552a30399db
2018-01-09Merge "res_pjsip.c: Fix endpoint identifier registration name search."Jenkins2
2018-01-09Merge "res_stasis: Fix dial bridge unload."Joshua Colp
2018-01-09Merge "res_pjsip_endpoint_identifier_ip.c: Fix apply identify validation."Jenkins2
2018-01-09res_pjsip_session: Always bundle streams if WebRTC is enabled.Joshua Colp
Some WebRTC clients can't handle renegotiation with the addition of streams that include an offer to bundle. They instead expect the newly added streams to already be bundled. This change does such a thing if WebRTC support is enabled on an endpoint. ASTERISK-27566 Change-Id: I7fe9b7ac35a2798627d9c2c8369129f407af6461
2018-01-08res_stasis: Reduce RAII_VAR usage.Corey Farrell
In addition to being a micro-optimization (RAII_VAR has overhead), this change improves output of REF_DEBUG. Unfortunately when RAII_VAR calls ao2_cleanup it does so from a generated _dtor_varname function. For example this caused _dtor_app to release a reference instead of __stasis_app_unregister. Change-Id: I4ce67120583a446babf9adeec678b71d37fcd9e5
2018-01-08Merge "res_stasis: Fix app_is_subscribed_bridge_id."Jenkins2
2018-01-08res_pjsip: Add AMI action 'PJSIPShowAuths'Sungtae Kim
Add an AMI action which provides information on all configured Auths. ASTERISK-27547 Change-Id: I1a88a75b38a2b1dd9d1de6c0307b20a3f584c817
2018-01-08Merge "General: Avoid implicit conversion to char when changes value to ↵Jenkins2
negative."
2018-01-07res_stasis: Fix dial bridge unload.Corey Farrell
If the dial bridge has been created it must be released by calling ast_bridge_destroy, simply releasing the ao2 reference is not enough. Also move stasis_app_control_shutdown earlier in unload to ensure the bridge cannot be created or grabbed after the app_bridges container is released. Change-Id: I372302de94ca63876069e2585a049c5060e5e767
2018-01-07res_stasis: Fix app_is_subscribed_bridge_id.Corey Farrell
Instead of searching for bridge_id provided in an argument this function always searched for BRIDGE_ALL first. Rewrite this function to work like the similar functions for channel and endpoint functions. Change-Id: Ib5caca69e11727c5c8a7284a1d00621f40f1e60a