dahdi_dynamic: dynamic drivers should not reference count themselves.

Move the try_module_get/module_put calls from the various dynamic
drivers into the "core" dahdi_dynamic.c file itself.  This way, a
reference count can always be held while calling through the function
pointers.  This is enabled by adding an .owner field to 'struct
dahdi_dynamic_driver'.

Dynamic spans are also unique in dahdi in that they require a "dahdi_cfg
-s" to stop them and release the references on the modules.  This is
counterintuitive. This change makes sure they are reference counted just
like other spans and on driver unload, if there aren't any open handles
from userspace, they will take care of unwinding themselves.

Signed-off-by: Shaun Ruffell <sruffell@digium.com>
Acked-by: Kinsey Moore <kmoore@digium.com>

git-svn-id: http://svn.asterisk.org/svn/dahdi/linux/trunk@9573 a0bf4364-ded3-4de4-8d8a-66a801d63aff

1 files changed, 6 insertions, 10 deletions

diff --git a/drivers/dahdi/dahdi_dynamic_loc.c b/drivers/dahdi/dahdi_dynamic_loc.c
index 72c8162..91d0289 100644
--- a/drivers/dahdi/dahdi_dynamic_loc.c
+++ b/drivers/dahdi/dahdi_dynamic_loc.c
@@ -146,7 +146,6 @@ static void dahdi_dynamic_local_destroy(void *pvt)
 
 	printk(KERN_INFO "TDMoL: Removed interface for %s, key %d "
 		"id %d\n", d->span->name, d->key, d->id);
-	module_put(THIS_MODULE);
 	kfree(d);
 }
 
@@ -216,9 +215,6 @@ static void *dahdi_dynamic_local_create(struct dahdi_span *span, char *address)
 	list_add(&d->node, &dynamic_local_list);
 	spin_unlock_irqrestore(&local_lock, flags);
 
-	if (!try_module_get(THIS_MODULE))
-		printk(KERN_DEBUG "TDMoL: Unable to increment module use count\n");
-
 	printk(KERN_INFO "TDMoL: Added new interface for %s, "
 	       "key %d id %d\n", span->name, d->key, d->id);
 	return d;
@@ -240,12 +236,12 @@ INVALID_ADDRESS:
 }
 
 static struct dahdi_dynamic_driver dahdi_dynamic_local = {
-	"loc",
-	"Local",
-	dahdi_dynamic_local_create,
-	dahdi_dynamic_local_destroy,
-	dahdi_dynamic_local_transmit,
-	NULL	/* flush */
+	.owner = THIS_MODULE,
+	.name = "loc",
+	.desc = "Local",
+	.create = dahdi_dynamic_local_create,
+	.destroy = dahdi_dynamic_local_destroy,
+	.transmit = dahdi_dynamic_local_transmit,
 };
 
 static int __init dahdi_dynamic_local_init(void)