diff options
| author | Mark Michelson <mmichelson@digium.com> | 2015-07-29 12:58:23 -0500 |
|---|---|---|
| committer | Mark Michelson <mmichelson@digium.com> | 2015-07-31 09:44:20 -0500 |
| commit | 86034227ca47ea256186372f09f83a4e18fcdc01 (patch) | |
| tree | 4fbaa4a0ded7ceee5dd10e8a4d6cf351c9fe14dc /include/asterisk/dns_resolver.h | |
| parent | 687597ca8c2412f79b79f9b13e17f3ec0ff0ce0c (diff) | |
dns_core: Allow zero-length DNS responses.
A testsuite test recently failed due to a crash that occurred in the DNS
core. The problem was that the test could not resolve an address, did
not set a result on the DNS query, and then indicated the query was
completed. The DNS core does not handle the case of a query with no
result gracefully, and so there is a crash.
This changeset makes the DNS system resolver set a result with a
zero-length answer in the case that a DNS resolution failure occurs
early. The DNS core now also will accept such a response without
treating it as invalid input. A unit test was updated to no longer treat
setting a zero-length response as off-nominal.
Change-Id: Ie56641e22debdaa61459e1c9a042e23b78affbf6
Diffstat (limited to 'include/asterisk/dns_resolver.h')
| -rw-r--r-- | include/asterisk/dns_resolver.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/include/asterisk/dns_resolver.h b/include/asterisk/dns_resolver.h index 819ce7a59..2d5f57f13 100644 --- a/include/asterisk/dns_resolver.h +++ b/include/asterisk/dns_resolver.h @@ -90,6 +90,10 @@ void *ast_dns_resolver_get_data(const struct ast_dns_query *query); * \param answer The raw DNS answer * \param answer_size The size of the raw DNS answer * + * Zero-sized and NULL answers are permitted by this function. This may be + * necessary if the query fails at an early stage and no actual DNS response + * has been received from a DNS server. + * * \retval 0 success * \retval -1 failure */ |