summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCorey Farrell <git@cfware.com>2017-11-18 21:02:17 -0500
committerCorey Farrell <git@cfware.com>2017-11-18 21:02:17 -0500
commit5a899fc50333525cb4c2dfe83aff3955472b8d0e (patch)
tree3ed845c18bfe754262680c6394745dc21e43261f
parent4181b6f3777655efa5f0523a8d2ab2b0e5e566fb (diff)
res_fax: Remove checks for unsigned values being >= 0.
It's impossible for gwtimeout or fdtimeout to be less than 0 because they are unsigned int's. Remove checks and unreachable branches. Change-Id: Ib2286960621e6ee245e40013c84986143302bc78
-rw-r--r--res/res_fax.c15
1 files changed, 2 insertions, 13 deletions
diff --git a/res/res_fax.c b/res/res_fax.c
index b25b6d16d..4a1c0846f 100644
--- a/res/res_fax.c
+++ b/res/res_fax.c
@@ -4561,12 +4561,7 @@ static int acf_faxopt_write(struct ast_channel *chan, const char *cmd, char *dat
unsigned int gwtimeout;
if (sscanf(timeout, "%30u", &gwtimeout) == 1) {
- if (gwtimeout >= 0) {
- details->gateway_timeout = gwtimeout * 1000;
- } else {
- ast_log(LOG_WARNING, "%s(%s) timeout cannot be negative. Ignoring timeout\n",
- cmd, data);
- }
+ details->gateway_timeout = gwtimeout * 1000;
} else {
ast_log(LOG_WARNING, "Unsupported timeout '%s' passed to FAXOPT(%s).\n", timeout, data);
}
@@ -4605,13 +4600,7 @@ static int acf_faxopt_write(struct ast_channel *chan, const char *cmd, char *dat
if (details->faxdetect_id < 0) {
if (timeout) {
if (sscanf(timeout, "%30u", &fdtimeout) == 1) {
- if (fdtimeout >= 0) {
- fdtimeout *= 1000;
- } else {
- ast_log(LOG_WARNING, "%s(%s) timeout cannot be negative. Ignoring timeout\n",
- cmd, data);
- fdtimeout = 0;
- }
+ fdtimeout *= 1000;
} else {
ast_log(LOG_WARNING, "Unsupported timeout '%s' passed to FAXOPT(%s).\n",
timeout, data);