diff options
| author | Joshua Colp <jcolp@digium.com> | 2017-02-07 18:01:03 +0000 |
|---|---|---|
| committer | Joshua Colp <jcolp@digium.com> | 2017-02-07 12:13:16 -0600 |
| commit | 861e5d2114c9c3cc0028c081d2a5249621917dfa (patch) | |
| tree | f9034510d1a70cf2c09a9d547e8fa235658e8b95 | |
| parent | 382f1d856f89fc3f4b0cfaec3038321250b4f15d (diff) | |
srv: Fix crash when ast_srv_lookup is used and 0 records are returned.
When performing an SRV lookup using the ast_srv_lookup function it
did not properly handle the situation where 0 records are returned.
If this happened it would wrongly assume that at least one record
was present.
This change fixes the code so it will exit early if an error occurs
or if 0 records are returned.
ASTERISK-26772
patches:
srv_lookup.patch submitted by nappsoft (license 6822)
Change-Id: I09b19081c74e0ad11c12bf54a257243b1bcb2351
| -rw-r--r-- | main/srv.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/main/srv.c b/main/srv.c index c07974991..e2dfb2b3c 100644 --- a/main/srv.c +++ b/main/srv.c @@ -211,7 +211,8 @@ int ast_srv_lookup(struct srv_context **context, const char *service, const char } AST_LIST_HEAD_INIT_NOLOCK(&(*context)->entries); - if ((ast_search_dns(*context, service, C_IN, T_SRV, srv_callback)) < 0) { + if (((ast_search_dns(*context, service, C_IN, T_SRV, srv_callback)) < 1) || + AST_LIST_EMPTY(&(*context)->entries)) { ast_free(*context); *context = NULL; return -1; |