summaryrefslogtreecommitdiff
path: root/apps/app_voicemail.c
diff options
context:
space:
mode:
authorCorey Farrell <git@cfware.com>2014-11-02 08:12:06 +0000
committerCorey Farrell <git@cfware.com>2014-11-02 08:12:06 +0000
commit5f17490f4d3101e674193ebafd6bd7a052a7c8d5 (patch)
tree8d8db16cb2f2866c6479722a08810b00138d3126 /apps/app_voicemail.c
parent54460c74e4a2c6226389a4e99f4731d5c4076627 (diff)
Fix ast_writestream leaks
Fix cleanup in __ast_play_and_record where others[x] may be leaked. This was caught where prepend != NULL && outmsg != NULL, once realfile[x] == NULL any further others[x] would be leaked. A cleanup block was also added for prepend != NULL && outmsg == NULL. 11+: Fix leak of ast_writestream recording_fs in app_voicemail:leave_voicemail. ASTERISK-24476 #close Reported by: Corey Farrell Review: https://reviewboard.asterisk.org/r/4138/ ........ Merged revisions 427023 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged revisions 427024 from http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged revisions 427025 from http://svn.asterisk.org/svn/asterisk/branches/12 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/13@427026 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'apps/app_voicemail.c')
-rw-r--r--apps/app_voicemail.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c
index af4e7f081..d99bced3d 100644
--- a/apps/app_voicemail.c
+++ b/apps/app_voicemail.c
@@ -6158,6 +6158,7 @@ static int msg_create_from_file(struct ast_vm_recording_data *recdata)
ast_log(LOG_ERROR,"Unable to determine sample rate of recording %s\n", recdata->recording_file);
}
}
+ ast_closeframe(recording_fs);
}
/* If the duration was below the minimum duration for the user, let's just drop the whole thing now */