diff options
| author | Corey Farrell <git@cfware.com> | 2017-11-07 12:49:35 -0500 |
|---|---|---|
| committer | Corey Farrell <git@cfware.com> | 2017-11-08 11:14:13 -0500 |
| commit | 05f557820bd4c9aec3d148b8d1f1909386fb11da (patch) | |
| tree | f8ac7446cc6a1f9bf2f68e59f70337e3d2b0346f /bridges | |
| parent | 38669ac57a353fb7d806acb8c75f32f0ec8ff9f2 (diff) | |
bridge_softmix: Note why ast_stream_topology_set_stream cannot fail.
This appeared in my audit of ast_stream_topology_set_stream callers
not checking for errors but in this situation the call cannot fail.
Add comment so this can be ignored in the future.
Change-Id: I91d25704859efbe50b8b82cfe1cd3c40ba177c9f
Diffstat (limited to 'bridges')
| -rw-r--r-- | bridges/bridge_softmix.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/bridges/bridge_softmix.c b/bridges/bridge_softmix.c index f490967e2..8de88f257 100644 --- a/bridges/bridge_softmix.c +++ b/bridges/bridge_softmix.c @@ -541,6 +541,8 @@ static int append_all_streams(struct ast_stream_topology *dest, dest_index++; if (ast_stream_get_state(stream) == AST_STREAM_STATE_REMOVED) { + /* This cannot fail because dest_index - 1 is less than the + * current count in dest. */ ast_stream_topology_set_stream(dest, dest_index - 1, clone); added = 1; break; |