summaryrefslogtreecommitdiff
path: root/cel
diff options
context:
space:
mode:
authorBadalyan Vyacheslav <v.badalyan@open-bs.ru>2016-10-10 12:49:08 -0400
committerJoshua Colp <jcolp@digium.com>2016-10-25 11:45:37 +0000
commit01d1d3763ff931b747bb4d1750c539cee2b57792 (patch)
treedd953331d250f8a13ce3f957f9f1786c9750f02d /cel
parent7c79b057dd3b0a06000b7bdd0583648bfc643b96 (diff)
cdr_radius,cel_radius: Fix old memleak in unload
- Call "rc_openlog" optional. If you do not call, you will simply NULL instead of a name. - On the one PID can be only one syslog channel. And it can already be run in logger.c - Calling rc_openlog we assigns a new name for the channel syslog. This unexpected behavior for logger.c. Most lesser evil, is to agree on a NULL name syslog if the channel was not launched in logger.c. It also solves the problem of memory leaks. ASTERISK-26455 #close Change-Id: Ic17c38de67583e971d78fe18807d1a9faf8f0afd
Diffstat (limited to 'cel')
-rw-r--r--cel/cel_radius.c12
1 files changed, 0 insertions, 12 deletions
diff --git a/cel/cel_radius.c b/cel/cel_radius.c
index 3c20e9780..f6ab89267 100644
--- a/cel/cel_radius.c
+++ b/cel/cel_radius.c
@@ -237,18 +237,6 @@ static int load_module(void)
return AST_MODULE_LOAD_DECLINE;
}
- /*
- * start logging
- *
- * NOTE: Yes this causes a slight memory leak if the module is
- * unloaded. However, it is better than a crash if cdr_radius
- * and cel_radius are both loaded.
- */
- tmp = ast_strdup("asterisk");
- if (tmp) {
- rc_openlog((char *) tmp);
- }
-
/* read radiusclient-ng config file */
if (!(rh = rc_read_config(radiuscfg))) {
ast_log(LOG_NOTICE, "Cannot load radiusclient-ng configuration file %s.\n", radiuscfg);