diff options
author | Matthew Jordan <mjordan@digium.com> | 2014-05-28 22:54:12 +0000 |
---|---|---|
committer | Matthew Jordan <mjordan@digium.com> | 2014-05-28 22:54:12 +0000 |
commit | fb5690ce4b9ff896a56fe9b9eb9eeed1a2b5f028 (patch) | |
tree | 5fc5aa9c8099167cf81dc9cfdadb19ce3aa24743 /cel | |
parent | 812f33d22218817f32ce856969e8196475f6d5fd (diff) |
Logger/CLI/etc.: Fix some aesthetic issues; reduce chatty verbose messages
This patch addresses some aesthetic issues in Asterisk. These are all just
minor tweaks to improve the look of the CLI when used in a variety of
settings. Specifically:
* A number of chatty verbose messages were removed or demoted to DEBUG
messages. Verbose messages with a verbosity level of 5 or higher were -
if kept as verbose messages - demoted to level 4. Several messages
that were emitted at verbose level 3 were demoted to 4, as announcement
of dialplan applications being executed occur at level 3 (and so the
effects of those applications should generally be less).
* Some verbose messages that only appear when their respective 'debug'
options are enabled were bumped up to always be displayed.
* Prefix/timestamping of verbose messages were moved to the verboser
handlers. This was done to prevent duplication of prefixes when the
timestamp option (-T) is used with the CLI.
* Verbose magic is removed from messages before being emitted to
non-verboser handlers. This prevents the magic in multi-line verbose
messages (such as SIP debug traces or the output of DumpChan) from
being written to files.
* _Slightly_ better support for the "light background" option (-W) was
added. This includes using ast_term_quit in the output of XML
documentation help, as well as changing the "Asterisk Ready" prompt to
bright green on the default background (which stands a better chance of
being displayed properly than bright white).
Review: https://reviewboard.asterisk.org/r/3547/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@414798 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'cel')
-rw-r--r-- | cel/cel_odbc.c | 3 | ||||
-rw-r--r-- | cel/cel_pgsql.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/cel/cel_odbc.c b/cel/cel_odbc.c index 87036bbf6..035857b68 100644 --- a/cel/cel_odbc.c +++ b/cel/cel_odbc.c @@ -761,8 +761,7 @@ static void odbc_log(struct ast_event *event) ast_str_append(&sql2, 0, ")"); ast_str_append(&sql, 0, "%s", ast_str_buffer(sql2)); - ast_verb(11, "[%s]\n", ast_str_buffer(sql)); - + ast_debug(3, "Executing SQL statement: [%s]\n", ast_str_buffer(sql)); stmt = ast_odbc_prepare_and_execute(obj, generic_prepare, ast_str_buffer(sql)); if (stmt) { SQLRowCount(stmt, &rows); diff --git a/cel/cel_pgsql.c b/cel/cel_pgsql.c index 7b1bd09ed..cd50af0e5 100644 --- a/cel/cel_pgsql.c +++ b/cel/cel_pgsql.c @@ -288,9 +288,8 @@ static void pgsql_log(struct ast_event *event) AST_RWLIST_UNLOCK(&psql_columns); LENGTHEN_BUF1(ast_str_strlen(sql2) + 2); ast_str_append(&sql, 0, ")%s)", ast_str_buffer(sql2)); - ast_verb(11, "[%s]\n", ast_str_buffer(sql)); - ast_debug(2, "inserting a CEL record.\n"); + ast_debug(3, "Inserting a CEL record: [%s].\n", ast_str_buffer(sql)); /* Test to be sure we're still connected... */ /* If we're connected, and connection is working, good. */ /* Otherwise, attempt reconnect. If it fails... sorry... */ |