diff options
author | Russell Bryant <russell@russellbryant.com> | 2008-05-05 20:28:17 +0000 |
---|---|---|
committer | Russell Bryant <russell@russellbryant.com> | 2008-05-05 20:28:17 +0000 |
commit | 27521f9e63ac93676c28916602b6f9403d214776 (patch) | |
tree | 893ffc625b52f2f19d15ee7e3242f967d9c365da /channels/chan_iax2.c | |
parent | 8aa3c0e2e194dadcee787adc8dcf502ef09d3cf8 (diff) |
Remove my rant, since I have now replaced the rant with code.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115315 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'channels/chan_iax2.c')
-rw-r--r-- | channels/chan_iax2.c | 15 |
1 files changed, 1 insertions, 14 deletions
diff --git a/channels/chan_iax2.c b/channels/chan_iax2.c index a41f6cf3f..3873d6b1f 100644 --- a/channels/chan_iax2.c +++ b/channels/chan_iax2.c @@ -1588,20 +1588,7 @@ static void remove_by_peercallno(struct chan_iax2_pvt *pvt) ao2_unlink(iax_peercallno_pvts, pvt); } -/*! - * \todo XXX Note that this function contains a very expensive operation that - * happens for *every* incoming media frame. It iterates through every - * possible call number, locking and unlocking each one, to try to match the - * incoming frame to an active call. Call numbers can be up to 2^15, 32768. - * So, for a call with a local call number of 20000, every incoming audio - * frame would require 20000 mutex lock and unlock operations. Ouch. - * - * It's a shame that IAX2 media frames carry the source call number instead of - * the destination call number. If they did, this lookup wouldn't be needed. - * However, it's too late to change that now. Instead, we need to come up with - * a better way of indexing active calls so that these frequent lookups are not - * so expensive. - * +/* * \note Calling this function while holding another pvt lock can cause a deadlock. */ static int __find_callno(unsigned short callno, unsigned short dcallno, struct sockaddr_in *sin, int new, int sockfd, int return_locked, int full_frame) |