diff options
| author | Michiel van Baak <michiel@vanbaak.info> | 2008-06-19 20:48:33 +0000 |
|---|---|---|
| committer | Michiel van Baak <michiel@vanbaak.info> | 2008-06-19 20:48:33 +0000 |
| commit | 8e8359465b7002ddb955fa898b3c57a35132683f (patch) | |
| tree | 7b42274bee0dd9b38bbd91570bf09a13d1c6aef0 /doc/CODING-GUIDELINES | |
| parent | 2e0afd805b263ba915a711f802ae3ad583644adc (diff) | |
Older versions of GNU gcc do not allow 'NULL' as sentinel.
They want (char *)NULL as sentinel.
An example is OpenBSD (confirmed on 4.3) that ships with gcc 3.3.4
This commit introduces a contstant SENTINEL which is declared as:
#define SENTINEL ((char *)NULL)
All places I could test compile on my openbsd system are converted.
Update CODING-GUIDELINES to tell about this constant.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124127 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'doc/CODING-GUIDELINES')
| -rw-r--r-- | doc/CODING-GUIDELINES | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/doc/CODING-GUIDELINES b/doc/CODING-GUIDELINES index aeca4a15b..53fd15da3 100644 --- a/doc/CODING-GUIDELINES +++ b/doc/CODING-GUIDELINES @@ -296,6 +296,15 @@ in other files. You will have to remove the "static" declaration and define a prototype in an appropriate header file (usually in include/asterisk). A more specific name should be given, such as "ast_find_call_feature". +* Variable function argument parsing +------------------------------------ + +Functions with a variable amount of argumenst need a 'sentinel' when called. +Newer GNU C compilers are fine if you use NULL for this. Older versions (pre 4) +don't like this. +You should use the constant SENTINEL. +This one is defined in include/asterisk/compiler.h + * Variable naming ----------------- |