diff options
| author | Richard Mudgett <rmudgett@digium.com> | 2013-08-28 23:15:43 +0000 |
|---|---|---|
| committer | Richard Mudgett <rmudgett@digium.com> | 2013-08-28 23:15:43 +0000 |
| commit | 186db8fdaf415f838c6c0bc29c9bd821ad3146c7 (patch) | |
| tree | 18d28030be38688e1208e005082aebb843090cba /funcs/func_cdr.c | |
| parent | 94e4733d89e9616f27888d0a88efc135318ecab4 (diff) | |
Fix some uninitialized buffers for CDR handling valgrind found.
* Made ast_strftime_locale() ensure that the output buffer is initialized.
The std library strftime() returns 0 and does not touch the buffer if it
has an error. However, the function can also return 0 without an error.
(closes issue ASTERISK-22412)
Reported by: rmudgett
........
Merged revisions 397902 from http://svn.asterisk.org/svn/asterisk/branches/12
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@397903 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'funcs/func_cdr.c')
| -rw-r--r-- | funcs/func_cdr.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/funcs/func_cdr.c b/funcs/func_cdr.c index 9c785112a..6d9fb19a1 100644 --- a/funcs/func_cdr.c +++ b/funcs/func_cdr.c @@ -213,6 +213,8 @@ static int cdr_read(struct ast_channel *chan, const char *cmd, char *parse, AST_APP_ARG(options); ); + buf[0] = '\0';/* Ensure the buffer is initialized. */ + if (!chan) { return -1; } |