diff options
| author | Richard Mudgett <rmudgett@digium.com> | 2013-08-28 22:24:01 +0000 |
|---|---|---|
| committer | Richard Mudgett <rmudgett@digium.com> | 2013-08-28 22:24:01 +0000 |
| commit | 5482fd21c882ba0afab82f10cb9679b916cba3bf (patch) | |
| tree | 50ebcfa7934ec834d4386227144dc0ea35403004 /funcs/func_cdr.c | |
| parent | 4ea0acbb44e5adad4ac74365e2c04a47ca67416e (diff) | |
Some CDR code optimization.
........
Merged revisions 397892 from http://svn.asterisk.org/svn/asterisk/branches/12
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@397893 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'funcs/func_cdr.c')
| -rw-r--r-- | funcs/func_cdr.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/funcs/func_cdr.c b/funcs/func_cdr.c index 52d7b1037..9c785112a 100644 --- a/funcs/func_cdr.c +++ b/funcs/func_cdr.c @@ -204,7 +204,6 @@ AST_APP_OPTIONS(cdr_func_options, { static int cdr_read(struct ast_channel *chan, const char *cmd, char *parse, char *buf, size_t len) { - char format_buf[128]; char *value = NULL; struct ast_flags flags = { 0 }; char tempbuf[512]; @@ -252,7 +251,7 @@ static int cdr_read(struct ast_channel *chan, const char *cmd, char *parse, return 0; } dtime = (double)(ms / 1000.0); - sprintf(tempbuf, "%lf", dtime); + snprintf(tempbuf, sizeof(tempbuf), "%lf", dtime); } else if (!ast_test_flag(&flags, OPT_UNPARSED)) { if (!strcasecmp("start", args.variable) || !strcasecmp("end", args.variable) @@ -278,8 +277,7 @@ static int cdr_read(struct ast_channel *chan, const char *cmd, char *parse, args.variable, tempbuf, ast_channel_name(chan)); return 0; } - sprintf(format_buf, "%s", ast_cdr_disp2str(disposition)); - strcpy(tempbuf, format_buf); + snprintf(tempbuf, sizeof(tempbuf), "%s", ast_cdr_disp2str(disposition)); } else if (!strcasecmp("amaflags", args.variable)) { int amaflags; @@ -288,8 +286,7 @@ static int cdr_read(struct ast_channel *chan, const char *cmd, char *parse, args.variable, tempbuf, ast_channel_name(chan)); return 0; } - sprintf(format_buf, "%s", ast_channel_amaflags2string(amaflags)); - strcpy(tempbuf, format_buf); + snprintf(tempbuf, sizeof(tempbuf), "%s", ast_channel_amaflags2string(amaflags)); } } |