summaryrefslogtreecommitdiff
path: root/funcs/func_odbc.c
diff options
context:
space:
mode:
authorSteve Murphy <murf@digium.com>2007-11-01 22:26:51 +0000
committerSteve Murphy <murf@digium.com>2007-11-01 22:26:51 +0000
commit63f2f04cf480569d7592874b5841d6287ffc5e80 (patch)
tree66604362a97aec13e31eae19ea0258e0042b8397 /funcs/func_odbc.c
parent842b1a34fefcac76ea8ef2d5c61c5aadc1bafc58 (diff)
This commits the performance mods that give the priority processing engine in the pbx, a 25-30% speed boost. The two updates used, are, first, to merge the ast_exists_extension() and the ast_spawn_extension() where they are called sequentially in a loop in the code, into a slightly upgraded version of ast_spawn_extension(), with a few extra args; and, second, I modified the substitute_variables_helper_full, so it zeroes out the byte after the evaluated string instead of demanding you pre-zero the buffer; I also went thru the code and removed the code that zeroed this buffer before every call to the substitute_variables_helper_full. The first fix provides about a 9% speedup, and the second the rest. These figures come from the 'PIPS' benchmark I describe in blogs, conf. reports, etc.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@88166 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'funcs/func_odbc.c')
-rw-r--r--funcs/func_odbc.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/funcs/func_odbc.c b/funcs/func_odbc.c
index 069eaf7cd..a2f895b2e 100644
--- a/funcs/func_odbc.c
+++ b/funcs/func_odbc.c
@@ -138,7 +138,7 @@ static int acf_odbc_write(struct ast_channel *chan, const char *cmd, char *s, co
{
struct odbc_obj *obj = NULL;
struct acf_odbc_query *query;
- char *t, buf[2048]="", varname[15];
+ char *t, buf[2048], varname[15];
int i, dsn, bogus_chan = 0;
AST_DECLARE_APP_ARGS(values,
AST_APP_ARG(field)[100];
@@ -256,7 +256,7 @@ static int acf_odbc_read(struct ast_channel *chan, const char *cmd, char *s, cha
{
struct odbc_obj *obj = NULL;
struct acf_odbc_query *query;
- char sql[2048] = "", varname[15], colnames[2048] = "", rowcount[12] = "-1";
+ char sql[2048], varname[15], colnames[2048] = "", rowcount[12] = "-1";
int res, x, y, buflen = 0, escapecommas, rowlimit = 1, dsn, bogus_chan = 0;
AST_DECLARE_APP_ARGS(args,
AST_APP_ARG(field)[100];