summaryrefslogtreecommitdiff
path: root/include/asterisk/event_defs.h
diff options
context:
space:
mode:
authorMatthew Jordan <mjordan@digium.com>2013-01-02 15:39:42 +0000
committerMatthew Jordan <mjordan@digium.com>2013-01-02 15:39:42 +0000
commit1fb06fde957fb466388c764384c2e14698e2dc15 (patch)
treee21651a29686d658d8dde28c54ddec92946497aa /include/asterisk/event_defs.h
parent2db81d7fc263ba609bd310b13abbbd8e0d3e3b82 (diff)
Resolve crashes due to large stack allocations when using TCP
Asterisk had several places where messages received over various network transports may be copied in a single stack allocation. In the case of TCP, since multiple packets in a stream may be concatenated together, this can lead to large allocations that overflow the stack. This patch modifies those portions of Asterisk using TCP to either favor heap allocations or use an upper bound to ensure that the stack will not overflow: * For SIP, the allocation now has an upper limit * For HTTP, the allocation is now a heap allocation instead of a stack allocation * For XMPP (in res_jabber), the allocation has been eliminated since it was unnecesary. Note that the HTTP portion of this issue was independently found by Brandon Edwards of Exodus Intelligence. (issue ASTERISK-20658) Reported by: wdoekes, Brandon Edwards Tested by: mmichelson, wdoekes patches: ASTERISK-20658_res_jabber.c.patch uploaded by mmichelson (license 5049) issueA20658_http_postvars_use_malloc2.patch uploaded by wdoekes (license 5674) issueA20658_limit_sip_packet_size3.patch uploaded by wdoekes (license 5674) ........ Merged revisions 378269 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged revisions 378286 from http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged revisions 378287 from http://svn.asterisk.org/svn/asterisk/branches/11 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@378288 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'include/asterisk/event_defs.h')
0 files changed, 0 insertions, 0 deletions