summaryrefslogtreecommitdiff
path: root/main/pbx.c
diff options
context:
space:
mode:
authorTerry Wilson <twilson@digium.com>2011-11-14 19:12:49 +0000
committerTerry Wilson <twilson@digium.com>2011-11-14 19:12:49 +0000
commit59d6db63bd90bee45d71c67f79e12f58f0aa9077 (patch)
tree0e665d2656058f71a855961a90aec5b7ceddff44 /main/pbx.c
parent6ef49c32147c7fdc28d72f0f2c117dfb591e3d50 (diff)
Don't read past end of input when calling write()
int blah = 1; ... write(chan->alertpipe[1], &blah, new_frames * sizeof(blah)) != (new_frames * sizeof(blah))) is only valid when new_frames == 1. Otherwise we start reading into adjacent variables declared on the stack. The read end discards what is read, so the values don't matter but it's not a good idea to read past where we want even though new_frames is almost always 1 and should never be large. This patch is basically taken out of kpfleming's eventfd branch, as he mentioned that he remembered fixing it there when I talked to him about this issue. Review: https://reviewboard.asterisk.org/r/1583/ ........ Merged revisions 345163 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged revisions 345164 from http://svn.asterisk.org/svn/asterisk/branches/10 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@345165 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'main/pbx.c')
0 files changed, 0 insertions, 0 deletions