summaryrefslogtreecommitdiff
path: root/main/sdp_state.c
diff options
context:
space:
mode:
authorSean Bright <sean.bright@gmail.com>2017-12-31 11:26:54 -0500
committerSean Bright <sean.bright@gmail.com>2017-12-31 11:34:41 -0500
commit15f8b9b8bfe340441950a67b16b3b5b74cc7d15e (patch)
treec3149a8a128c0046330c4f1b878333e8f54ac94f /main/sdp_state.c
parent80e6b2eff54a4ff57e2521164224b1b1c878ae94 (diff)
ice: Increase foundation buffer size
Per RFC 5245, the foundation specified with an ICE candidate can be up to 32 characters but we are only allowing for 31. ASTERISK-27498 #close Reported by: Michele PrĂ  Change-Id: I05ce7a5952721a76a2b4c90366168022558dc7cf
Diffstat (limited to 'main/sdp_state.c')
-rw-r--r--main/sdp_state.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/main/sdp_state.c b/main/sdp_state.c
index bccde612a..5f9ad5eb9 100644
--- a/main/sdp_state.c
+++ b/main/sdp_state.c
@@ -2171,7 +2171,7 @@ static void update_ice(const struct ast_sdp_state *state, struct ast_rtp_instanc
/* Find all of the candidates */
for (attr_i = 0; attr_i < ast_sdp_m_get_a_count(remote_m_line); ++attr_i) {
- char foundation[32];
+ char foundation[33];
char transport[32];
char address[INET6_ADDRSTRLEN + 1];
char cand_type[6];
@@ -2187,7 +2187,7 @@ static void update_ice(const struct ast_sdp_state *state, struct ast_rtp_instanc
continue;
}
- if (sscanf(attr->value, "%31s %30u %31s %30u %46s %30u typ %5s %*s %23s %*s %30u",
+ if (sscanf(attr->value, "%32s %30u %31s %30u %46s %30u typ %5s %*s %23s %*s %30u",
foundation, &candidate.id, transport, (unsigned *)&candidate.priority, address,
&port, cand_type, relay_address, &relay_port) < 7) {
/* Candidate did not parse properly */