diff options
| author | Jeff Peeler <jpeeler@digium.com> | 2008-10-03 22:40:59 +0000 |
|---|---|---|
| committer | Jeff Peeler <jpeeler@digium.com> | 2008-10-03 22:40:59 +0000 |
| commit | 4b22fb221c28a5ec21f1aa291b8113266d3cd87a (patch) | |
| tree | 0a01d2bdea1ef7fb2ecb47a665ccaa8061276c8d /main | |
| parent | b29fb615ae4dc5da616c3beb223b4a01f42d7238 (diff) | |
remove superfluous reference counting operations in manage_parkinglot since ao2_interator_next increments the ref count automatically
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146242 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'main')
| -rw-r--r-- | main/features.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/main/features.c b/main/features.c index a8333728e..a3bc2d5c3 100644 --- a/main/features.c +++ b/main/features.c @@ -2500,7 +2500,7 @@ static void post_manager_event(const char *s, struct parkeduser *pu) ); } -/*! \brief Run management on parkinglots, collad once per parkinglot */ +/*! \brief Run management on parkinglots, called once per parkinglot */ int manage_parkinglot(struct ast_parkinglot *curlot, fd_set *rfds, fd_set *efds, fd_set *nrfds, fd_set *nefds, int *ms, int *max) { @@ -2508,8 +2508,6 @@ int manage_parkinglot(struct ast_parkinglot *curlot, fd_set *rfds, fd_set *efds, int res = 0; char parkingslot[AST_MAX_EXTENSION]; - /* TODO: I believe this reference increase is not necessary since the iterator in the calling function already did so */ - //parkinglot_addref(curlot); /* Lock parking list */ AST_LIST_LOCK(&curlot->parkings); AST_LIST_TRAVERSE_SAFE_BEGIN(&curlot->parkings, pu, list) { @@ -2593,7 +2591,6 @@ int manage_parkinglot(struct ast_parkinglot *curlot, fd_set *rfds, fd_set *efds, } else ast_log(LOG_WARNING, "Whoa, no parking context?\n"); AST_LIST_REMOVE_CURRENT(list); - parkinglot_unref(curlot); } else { /* still within parking time, process descriptors */ for (x = 0; x < AST_MAX_FDS; x++) { struct ast_frame *f; @@ -2628,7 +2625,6 @@ int manage_parkinglot(struct ast_parkinglot *curlot, fd_set *rfds, fd_set *efds, } else ast_log(LOG_WARNING, "Whoa, no parking context for parking lot %s?\n", curlot->name); AST_LIST_REMOVE_CURRENT(list); - parkinglot_unref(curlot); break; } else { /* XXX Maybe we could do something with packets, like dial "0" for operator or something XXX */ |