diff options
author | Matt Jordan <mjordan@digium.com> | 2016-05-18 06:19:58 -0500 |
---|---|---|
committer | Matt Jordan <mjordan@digium.com> | 2016-05-20 09:06:12 -0500 |
commit | e773e3a9bbaf378d53647e4bac3ffcd61afb4ae6 (patch) | |
tree | 23e75dcdaf9b8c72a23387bfabdd42f643e5c480 /res/res_ari_recordings.c | |
parent | d4b77dad1b0154eb3b89133d941dd8d624deda54 (diff) |
ARI: Add the ability to download the media associated with a stored recording
This patch adds a new feature to ARI that allows a client to download
the media associated with a stored recording. The new route is
/recordings/stored/{name}/file, and transmits the underlying binary file
using Asterisk's HTTP server's underlying file transfer facilities.
Because this REST route returns non-JSON, a few small enhancements had
to be made to the Python Swagger generation code, as well as the
mustache templates that generate the ARI bindings.
ASTERISK-26042 #close
Change-Id: I49ec5c4afdec30bb665d9c977ab423b5387e0181
Diffstat (limited to 'res/res_ari_recordings.c')
-rw-r--r-- | res/res_ari_recordings.c | 72 |
1 files changed, 70 insertions, 2 deletions
diff --git a/res/res_ari_recordings.c b/res/res_ari_recordings.c index df4a124be..abc264d9e 100644 --- a/res/res_ari_recordings.c +++ b/res/res_ari_recordings.c @@ -221,6 +221,65 @@ static void ast_ari_recordings_delete_stored_cb( fin: __attribute__((unused)) return; } +/*! + * \brief Parameter parsing callback for /recordings/stored/{recordingName}/file. + * \param get_params GET parameters in the HTTP request. + * \param path_vars Path variables extracted from the request. + * \param headers HTTP headers. + * \param[out] response Response to the HTTP request. + */ +static void ast_ari_recordings_get_stored_file_cb( + struct ast_tcptls_session_instance *ser, + struct ast_variable *get_params, struct ast_variable *path_vars, + struct ast_variable *headers, struct ast_ari_response *response) +{ + struct ast_ari_recordings_get_stored_file_args args = {}; + struct ast_variable *i; + RAII_VAR(struct ast_json *, body, NULL, ast_json_unref); +#if defined(AST_DEVMODE) + int is_valid; + int code; +#endif /* AST_DEVMODE */ + + for (i = path_vars; i; i = i->next) { + if (strcmp(i->name, "recordingName") == 0) { + args.recording_name = (i->value); + } else + {} + } + ast_ari_recordings_get_stored_file(ser, headers, &args, response); +#if defined(AST_DEVMODE) + code = response->response_code; + + switch (code) { + case 0: /* Implementation is still a stub, or the code wasn't set */ + is_valid = response->message == NULL; + break; + case 500: /* Internal Server Error */ + case 501: /* Not Implemented */ + case 404: /* Recording not found */ + is_valid = 1; + break; + default: + if (200 <= code && code <= 299) { + /* No validation on a raw binary response */ + is_valid = 1; + } else { + ast_log(LOG_ERROR, "Invalid error response %d for /recordings/stored/{recordingName}/file\n", code); + is_valid = 0; + } + } + + if (!is_valid) { + ast_log(LOG_ERROR, "Response validation failed for /recordings/stored/{recordingName}/file\n"); + ast_ari_response_error(response, 500, + "Internal Server Error", "Response validation failed"); + } +#endif /* AST_DEVMODE */ + +fin: __attribute__((unused)) + return; +} int ast_ari_recordings_copy_stored_parse_body( struct ast_json *body, struct ast_ari_recordings_copy_stored_args *args) @@ -738,6 +797,15 @@ fin: __attribute__((unused)) } /*! \brief REST handler for /api-docs/recordings.{format} */ +static struct stasis_rest_handlers recordings_stored_recordingName_file = { + .path_segment = "file", + .callbacks = { + [AST_HTTP_GET] = ast_ari_recordings_get_stored_file_cb, + }, + .num_children = 0, + .children = { } +}; +/*! \brief REST handler for /api-docs/recordings.{format} */ static struct stasis_rest_handlers recordings_stored_recordingName_copy = { .path_segment = "copy", .callbacks = { @@ -754,8 +822,8 @@ static struct stasis_rest_handlers recordings_stored_recordingName = { [AST_HTTP_GET] = ast_ari_recordings_get_stored_cb, [AST_HTTP_DELETE] = ast_ari_recordings_delete_stored_cb, }, - .num_children = 1, - .children = { &recordings_stored_recordingName_copy, } + .num_children = 2, + .children = { &recordings_stored_recordingName_file,&recordings_stored_recordingName_copy, } }; /*! \brief REST handler for /api-docs/recordings.{format} */ static struct stasis_rest_handlers recordings_stored = { |