summaryrefslogtreecommitdiff
path: root/res/res_hep_rtcp.c
diff options
context:
space:
mode:
authorMatt Jordan <mjordan@digium.com>2016-06-08 12:26:29 -0500
committerMatt Jordan <mjordan@digium.com>2016-06-08 12:32:02 -0500
commit7f5ca67e5fbc6d4e39a8f1f881faea568770819f (patch)
tree3f1d4f96af64084396d54c730ef9fedd62852f19 /res/res_hep_rtcp.c
parent5164e1fd859fcd884a4b9edef7cde3b6e1efc87a (diff)
res_hep_{pjsip|rtcp}: Decline module loads if res_hep had not loaded
A crash can occur in res_hep_pjsip or res_hep_rtcp if res_hep has not loaded and does not have a configuration file. Previously when this occurred, checks were put in to see if the configuration was loaded successfully. While this is a good idea - and has been added to the offending function in res_hep - the reality is res_hep_pjsip and res_hep_rtcp have no business running if res_hep isn't also running. As such, this patch also adds a function to res_hep that returns whether or not it successfully loaded. Oddly enough, ast_module_check returns "everything is peachy" even if a module declined its load - so it cannot be solely relied on. res_hep_pjsip and res_hep_rtcp now also check this function to see if they should continue to load; if it fails, they decline their load as well. ASTERISK-26096 #close Change-Id: I007e535fcc2e51c2ca48534f48c5fc2ac38935ea
Diffstat (limited to 'res/res_hep_rtcp.c')
-rw-r--r--res/res_hep_rtcp.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/res/res_hep_rtcp.c b/res/res_hep_rtcp.c
index 8643d4db6..03db18159 100644
--- a/res/res_hep_rtcp.c
+++ b/res/res_hep_rtcp.c
@@ -149,6 +149,10 @@ static void rtp_topic_handler(void *data, struct stasis_subscription *sub, struc
static int load_module(void)
{
+ if (!ast_module_check("res_hep.so") || !hepv3_is_loaded()) {
+ ast_log(AST_LOG_WARNING, "res_hep is not loaded or running; declining module load\n");
+ return AST_MODULE_LOAD_DECLINE;
+ }
stasis_rtp_subscription = stasis_subscribe(ast_rtp_topic(),
rtp_topic_handler, NULL);