summaryrefslogtreecommitdiff
path: root/res/res_pjsip_session.c
diff options
context:
space:
mode:
authorKevin Harwell <kharwell@digium.com>2017-08-04 16:47:30 -0500
committerKevin Harwell <kharwell@digium.com>2017-08-04 17:16:25 -0500
commit09995fae5376a5ab6184a916076108f4af0640b5 (patch)
treeeb427d51eb34ba0e5f3399d535aa55d9c64ab9f5 /res/res_pjsip_session.c
parent2014a695f735d14456b5631bec9e2a32a8226609 (diff)
res_pjsip_session/_sdp_rtp: Handling of 'msid' is incorrect
Currently, the handling of the msid attribute is not quite right. According to the spec the msid's between the offer/answer are not dependent upon one another. Meaning the same msid's given in an offer do not have to be returned in the answer for a given stream. And they probably shouldn't be (copied/reused) since this can potentially cause some browser side confusion. This patch generates new msids when both an offer and answer are sent from Asterisk. However, Asterisk does reuse the original msid it sent out for a reinvite. Also audio+video streams are paired together by sharing the same stream id, but a different track id. ASTERISK-27179 #close Change-Id: Ifaec06dc7e65ad841633a24ebec8c8a9302d6643
Diffstat (limited to 'res/res_pjsip_session.c')
-rw-r--r--res/res_pjsip_session.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/res/res_pjsip_session.c b/res/res_pjsip_session.c
index bb349a4b6..607f329ab 100644
--- a/res/res_pjsip_session.c
+++ b/res/res_pjsip_session.c
@@ -395,7 +395,6 @@ static void session_media_dtor(void *obj)
}
ast_free(session_media->mid);
- ast_free(session_media->msid);
}
struct ast_sip_session_media *ast_sip_session_media_state_add(struct ast_sip_session *session,