diff options
| author | Kinsey Moore <kmoore@digium.com> | 2012-07-31 20:21:43 +0000 |
|---|---|---|
| committer | Kinsey Moore <kmoore@digium.com> | 2012-07-31 20:21:43 +0000 |
| commit | 9b16c8b0f6c3b6310e303411421bfcb16b26c3c4 (patch) | |
| tree | 273c31a834a21bd2239ec6b83cd35c602ea25d26 /tests/test_linkedlists.c | |
| parent | 6c23a60f802e7708389b1a6463a40dc0500512bd (diff) | |
Clean up and ensure proper usage of alloca()
This replaces all calls to alloca() with ast_alloca() which calls gcc's
__builtin_alloca() to avoid BSD semantics and removes all NULL checks
on memory allocated via ast_alloca() and ast_strdupa().
(closes issue ASTERISK-20125)
Review: https://reviewboard.asterisk.org/r/2032/
Patch-by: Walter Doekes (wdoekes)
........
Merged revisions 370642 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........
Merged revisions 370643 from http://svn.asterisk.org/svn/asterisk/branches/10
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@370655 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'tests/test_linkedlists.c')
| -rw-r--r-- | tests/test_linkedlists.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/tests/test_linkedlists.c b/tests/test_linkedlists.c index 22005139b..2aee5c9a2 100644 --- a/tests/test_linkedlists.c +++ b/tests/test_linkedlists.c @@ -150,7 +150,7 @@ AST_TEST_DEFINE(single_ll_tests) return AST_TEST_FAIL; } - if (!(bogus = alloca(sizeof(*bogus)))) { + if (!(bogus = ast_alloca(sizeof(*bogus)))) { return AST_TEST_FAIL; } @@ -361,9 +361,7 @@ AST_TEST_DEFINE(double_ll_tests) return AST_TEST_FAIL; } - if (!(bogus = alloca(sizeof(*bogus)))) { - return AST_TEST_FAIL; - } + bogus = ast_alloca(sizeof(*bogus)); if (AST_DLLIST_REMOVE_VERIFY(&test_list, bogus, dbl_list)) { ast_test_status_update(test, "AST_DLLIST_REMOVE_VERIFY should safely return NULL for missing element from empty list\n"); |