summaryrefslogtreecommitdiff
path: root/utils
diff options
context:
space:
mode:
authorDavid M. Lee <dlee@digium.com>2014-02-27 16:26:18 +0000
committerDavid M. Lee <dlee@digium.com>2014-02-27 16:26:18 +0000
commitbe3cab0a3aa1423c6789d5fe0b8b7f9adef6714f (patch)
tree5a84aaac7fdfe2fabd502935f89963cebfa752de /utils
parent3ee8cf6efb055ae75aff96bfdf5a198a10033f62 (diff)
Fix memory stomping bug in astman.
This memset complained in dev mod on my Ubuntu box. The memset is both unnecessary and dangerous. At this point, m hasn't been initialized yet, so the memset will write off to whatever address happens to be on the stack at the time. ........ Merged revisions 409077 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged revisions 409083 from http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged revisions 409087 from http://svn.asterisk.org/svn/asterisk/branches/12 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@409091 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Diffstat (limited to 'utils')
-rw-r--r--utils/astman.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/utils/astman.c b/utils/astman.c
index 6527e994a..3e9ca8ffb 100644
--- a/utils/astman.c
+++ b/utils/astman.c
@@ -737,7 +737,6 @@ static int manager_login(char *hostname)
show_message("Login Failed", get_header(m, "Message"));
}
} else {
- memset(m, 0, sizeof(*m));
manager_action("Login",
"Username: %s\r\n"
"Secret: %s\r\n",