diff options
| author | trowbrds <trowbrds@5efc13c4-1f27-0410-8691-ff2d1f55687e> | 2009-07-26 22:39:59 +0000 |
|---|---|---|
| committer | trowbrds <trowbrds@5efc13c4-1f27-0410-8691-ff2d1f55687e> | 2009-07-26 22:39:59 +0000 |
| commit | 975ef607f1fcb8c375b2cf52a05db4de9460a823 (patch) | |
| tree | a21a7c7e79864cbb3202955cc36404956a61e054 | |
| parent | 08f442039427b962142d48b821885cd6f7eec789 (diff) | |
Perforce binary file diff corruption fix.
When a binary file differed, post-review would miss printing a newline after
"Binary Files differ", making the diff invalid for the subsequent file. This
would cause that file's diff to be lost silently when parsed by reviewboard on
the server side. Patch from Chris Trimble.
Reviewed at http://reviews.review-board.org/r/915/
| -rwxr-xr-x | rbtools/postreview.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/rbtools/postreview.py b/rbtools/postreview.py index 9f50f2c..d5cda25 100755 --- a/rbtools/postreview.py +++ b/rbtools/postreview.py @@ -1665,6 +1665,7 @@ class PerforceClient(SCMClient): dl.insert(0, "==== %s#%s ==%s== %s ====\n" % \ (depot_path, base_revision, changetype_short, local_path)) + dl.append('\n') else: m = re.search(r'(\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d)', dl[1]) if m: |